Improve offline mode error page

Thibaut committed 11 years ago

Commit 1252b361 parent 74ea6814 files · +23 −8Browse files

Unified · Split

4 files

         @checkedBuggyIDB = true
     catch
       try db.close()
+      @reason = 'apple'
       @onOpenError()
       return
       app.onQuotaExceeded()
     else
       @useIndexedDB = false
+      @reason or= 'cant_open'
       @runCallbacks()
     return
   useIndexedDB: ->
     try
-      !app.isSingleDoc() and !!window.indexedDB
+      if !app.isSingleDoc() and window.indexedDB
+        true
+      else
+        @reason = 'not_supported'
+        false
     catch
       false

         """ Check your Internet connection and try <a href="javascript:location.reload()">reloading</a>.<br>
             If you keep seeing this, you're likely behind a proxy or firewall that blocks cross-domain requests. """
-app.templates.offlineError = ->
+app.templates.offlineError = (reason) ->
-  error """ Oops, the database failed to load. """,
+  reason = switch reason
-        """ DevDocs requires IndexedDB to cache documentations for offline access.<br>
+    when 'not_supported'
-            Unfortunately IndexedDB is either not supported in your browser, disabled, or buggy. """
+      """ Unfortunately your browser either doesn't support it or does not make it available. """
+    when 'cant_open'
+      """ Although your browser appears to support it, DevDocs couldn't open the database.<br>
+          This could be because you're browsing in private mode and have disallowed offline storage on the domain. """
+    when 'apple'
+      """ Unfortunately Safari's implementation of IndexedDB is <a href="https://bugs.webkit.org/show_bug.cgi?id=136937">badly broken</a>.<br>
+          This message will automatically go away when Apple fix their code. """
+  error """ Oops, offline mode is unavailable. """,
+        """ DevDocs requires IndexedDB to cache documentations for offline access.<br>#{reason} """
 app.templates.unsupportedBrowser = """
   <div class="_fail">

@@ -14,7 +14,7 @@ class app.views.OfflinePage extends app.View · 13 unmodified lines
14	app.docs.getInstallStatuses (statuses) =>	14	app.docs.getInstallStatuses (statuses) =>
15	return unless @activated	15	return unless @activated
16	if statuses is false	16	if statuses is false
17	@html @tmpl('offlineError')	17	@html @tmpl('offlineError', app.db.reason)
18	else	18	else
19	html = ''	19	html = ''
20	html += @renderDoc(doc, statuses[doc.slug]) for doc in app.docs.all()	20	html += @renderDoc(doc, statuses[doc.slug]) for doc in app.docs.all()