History

outdated_state: omit 0. and 1. versions

Simon Legner committed 4 years ago

Commit 200e39c1 parent 1e61abf2 files · +7 −1Browse files

Unified · Split

2 files
  1. lib/docs/core/doc.rb +2 −0
  2. test/lib/docs/core/doc_test.rb +5 −1
lib/docs/core/doc.rb+2−0
@@ -203,6 +203,8 @@ module Docs · 202 unmodified lines
203 [0, 1].each do |i|203 [0, 1].each do |i|
204 break if i >= scraper_parts.length or i >= latest_parts.length204 break if i >= scraper_parts.length or i >= latest_parts.length
205 return 'Outdated major version' if i == 0 and latest_parts[i] > scraper_parts[i]205 return 'Outdated major version' if i == 0 and latest_parts[i] > scraper_parts[i]
206 return 'Outdated major version' if i == 1 and latest_parts[i] > scraper_parts[i] and latest_parts[0] == 0 and scraper_parts[0] == 0
207 return 'Outdated major version' if i == 1 and latest_parts[i] > scraper_parts[i] and latest_parts[0] == 1 and scraper_parts[0] == 1
206 return 'Outdated minor version' if i == 1 and latest_parts[i] > scraper_parts[i]208 return 'Outdated minor version' if i == 1 and latest_parts[i] > scraper_parts[i]
207 return 'Up-to-date' if latest_parts[i] < scraper_parts[i]209 return 'Up-to-date' if latest_parts[i] < scraper_parts[i]
208 end210 end
test/lib/docs/core/doc_test.rb+5−1
@@ -390,12 +390,16 @@ class DocsDocTest < MiniTest::Spec · 389 unmodified lines
390 390
391 it "compares versions" do391 it "compares versions" do
392 instance = doc.versions.first.new392 instance = doc.versions.first.new
393 assert_equal "Up-to-date", instance.outdated_state('0.0.2', '0.0.3')
394 assert_equal "Outdated major version", instance.outdated_state('0.2', '0.3')
393 assert_equal 'Up-to-date', instance.outdated_state('1', '1')395 assert_equal 'Up-to-date', instance.outdated_state('1', '1')
394 assert_equal 'Up-to-date', instance.outdated_state('1.2', '1.2')396 assert_equal 'Up-to-date', instance.outdated_state('1.2', '1.2')
395 assert_equal 'Up-to-date', instance.outdated_state('1.2.2', '1.2.2')397 assert_equal 'Up-to-date', instance.outdated_state('1.2.2', '1.2.2')
396 assert_equal 'Up-to-date', instance.outdated_state('1.2.2', '1.2.3')398 assert_equal 'Up-to-date', instance.outdated_state('1.2.2', '1.2.3')
397 assert_equal "Outdated major version", instance.outdated_state('1', '2')399 assert_equal "Outdated major version", instance.outdated_state('1', '2')
398 assert_equal "Outdated minor version", instance.outdated_state('1.2', '1.3')400 assert_equal "Up-to-date", instance.outdated_state('1.0.2', '1.0.3')
401 assert_equal "Outdated major version", instance.outdated_state('1.2', '1.3')
402 assert_equal "Outdated minor version", instance.outdated_state('2.2', '2.3')
399 assert_equal "Outdated major version", instance.outdated_state('9', '10')403 assert_equal "Outdated major version", instance.outdated_state('9', '10')
400 assert_equal "Outdated major version", instance.outdated_state('99', '101')404 assert_equal "Outdated major version", instance.outdated_state('99', '101')
401 assert_equal 'Up-to-date', instance.outdated_state('2006-01-02', '2006-01-03')405 assert_equal 'Up-to-date', instance.outdated_state('2006-01-02', '2006-01-03')