History

Specs all passing

Paul Sernatinger committed 4 years ago

Commit 2da05d71 parent b3e55ed37 files · +198 −178Browse files

Showing the changes to test (28 of 37 files). Show all

Unified · Split

28 files
  1. test/lib/docs/core/doc_test.rb +5 −5
  2. test/lib/docs/core/entry_index_test.rb +2 −2
  3. test/lib/docs/core/filter_test.rb +3 −3
  4. test/lib/docs/core/instrumentable_test.rb +2 −2
  5. test/lib/docs/core/manifest_test.rb +2 −2
  6. test/lib/docs/core/models/entry_test.rb +2 −2
  7. test/lib/docs/core/models/type_test.rb +2 −2
  8. test/lib/docs/core/parser_test.rb +2 −2
  9. test/lib/docs/core/request_test.rb +4 −4
  10. test/lib/docs/core/requester_test.rb +4 −4
  11. test/lib/docs/core/response_test.rb +2 −2
  12. test/lib/docs/core/scraper_test.rb +3 −3
  13. test/lib/docs/core/scrapers/file_scraper_test.rb +2 −2
  14. test/lib/docs/core/scrapers/url_scraper_test.rb +7 −7
  15. test/lib/docs/core/url_test.rb +2 −2
  16. test/lib/docs/filters/core/apply_base_url_test.rb +2 −2
  17. test/lib/docs/filters/core/clean_html_test.rb +2 −2
  18. test/lib/docs/filters/core/clean_text_test.rb +2 −2
  19. test/lib/docs/filters/core/container_test.rb +2 −2
  20. test/lib/docs/filters/core/entries_test.rb +2 −2
  21. test/lib/docs/filters/core/inner_html_test.rb +2 −2
  22. test/lib/docs/filters/core/internal_urls_test.rb +2 −2
  23. test/lib/docs/filters/core/normalize_paths_test.rb +2 −2
  24. test/lib/docs/filters/core/normalize_urls_test.rb +2 −2
  25. test/lib/docs/filters/core/parse_cf_email_test.rb +2 −2
  26. test/lib/docs/filters/core/title_test.rb +2 −2
  27. test/lib/docs/storage/abstract_store_test.rb +3 −3
  28. test/lib/docs/storage/file_store_test.rb +2 −2
test/lib/docs/core/doc_test.rb+5−5
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsDocTest < MiniTest::Spec
55 let :doc do
@@ -197,7 +197,7 @@ class DocsDocTest < MiniTest::Spec · 191 unmodified lines
197197 it "opens the .path directory before storing the file" do
198198 stub(doc).path { 'path' }
199199 stub(store).write { assert false }
200− mock(store).open('path') do |_, block|
200+ mock(store).open('path') do |_, &block|
201201 stub(store).write
202202 block.call
203203 end
@@ -258,7 +258,7 @@ class DocsDocTest < MiniTest::Spec · 54 unmodified lines
258258
259259 before do
260260 any_instance_of(doc) do |instance|
261− stub(instance).build_pages { |block| pages.each(&block) }
261+ stub(instance).build_pages { |&block| pages.each(&block) }
262262 end
263263 end
264264
@@ -313,7 +313,7 @@ class DocsDocTest < MiniTest::Spec · 48 unmodified lines
313313 it "replaces the .path directory before storing the files" do
314314 stub(doc).path { 'path' }
315315 stub(store).write { assert false }
316− mock(store).replace('path') do |_, block|
316+ mock(store).replace('path') do |_, &block|
317317 stub(store).write
318318 block.call
319319 end
test/lib/docs/core/entry_index_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsEntryIndexTest < MiniTest::Spec
55 let :entry do
test/lib/docs/core/filter_test.rb+3−3
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsFilterTest < MiniTest::Spec
55 include FilterTestHelper
@@ -19,7 +19,7 @@ class DocsFilterTest < MiniTest::Spec · 13 unmodified lines
1919
2020 describe "#subpath_to" do
2121 it "returns the subpath from the #base_url to the url, ignoring case" do
22− stub(filter.base_url).subpath_to('url', hash_including(ignore_case: true)) { 'subpath' }
22+ stub(filter.base_url).subpath_to('url', ignore_case: true) { 'subpath' }
2323 assert_equal 'subpath', filter.subpath_to('url')
2424 end
2525 end
test/lib/docs/core/instrumentable_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsInstrumentableTest < MiniTest::Spec
55 let :extended_class do
test/lib/docs/core/manifest_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class ManifestTest < MiniTest::Spec
55 let :doc do
test/lib/docs/core/models/entry_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class DocsEntryTest < MiniTest::Spec
55 Entry = Docs::Entry
test/lib/docs/core/models/type_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class DocsTypeTest < MiniTest::Spec
55 Type = Docs::Type
test/lib/docs/core/parser_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsParserTest < MiniTest::Spec
55 def parser(content)
test/lib/docs/core/request_test.rb+4−4
@@ -1,13 +1,13 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsRequestTest < MiniTest::Spec
55 let :url do
66 'http://example.com'
77 end
88
9− def request(url = self.url, options = {})
10− Docs::Request.new(url, options).tap do |request|
9+ def request(url = self.url, **options)
10+ Docs::Request.new(url, **options).tap do |request|
1111 request.extend FakeInstrumentation
1212 end
1313 end
test/lib/docs/core/requester_test.rb+4−4
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsRequesterTest < MiniTest::Spec
55 def stub_request(url)
@@ -7,7 +7,7 @@ class DocsRequesterTest < MiniTest::Spec · 1 unmodified line
77 end
88
99 let :requester do
10− Docs::Requester.new(options)
10+ Docs::Requester.new(**options)
1111 end
1212
1313 let :url do
@@ -81,7 +81,7 @@ class DocsRequesterTest < MiniTest::Spec · 67 unmodified lines
8181 end
8282
8383 it "returns an array of requests" do
84− result = requester.request(urls, { params: 'test' }, &block)
84+ result = requester.request(urls, params: 'test', &block)
8585 assert_instance_of Array, result
8686 assert_equal urls.length, result.length
8787 assert result.all? { |obj| obj.instance_of? Docs::Request }
test/lib/docs/core/response_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsResponseTest < MiniTest::Spec
55 let :response do
test/lib/docs/core/scraper_test.rb+3−3
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsScraperTest < MiniTest::Spec
55 class Scraper < Docs::Scraper
@@ -223,7 +223,7 @@ class DocsScraperTest < MiniTest::Spec · 217 unmodified lines
223223
224224 context "when the response is processable" do
225225 before do
226− stub(scraper).request_all do |urls, block|
226+ stub(scraper).request_all do |urls, &block|
227227 urls.each { |url| @next_urls ||= block.call(response) }
228228 end
229229 stub(scraper).handle_response(response) { processed_response }
test/lib/docs/core/scrapers/file_scraper_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class FileScraperTest < MiniTest::Spec
55 ROOT_PATH = File.expand_path('../../../../../../', __FILE__)
test/lib/docs/core/scrapers/url_scraper_test.rb+7−7
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class DocsUrlScraperTest < MiniTest::Spec
55 class Scraper < Docs::UrlScraper
@@ -54,29 +54,29 @@ class DocsUrlScraperTest < MiniTest::Spec · 48 unmodified lines
5454 end
5555
5656 it "runs a Requester with the given urls" do
57− mock(Docs::Requester).run 'urls', anything
57+ mock(Docs::Requester).run('urls', request_options: {params: {}, headers: {"User-Agent" => "DevDocs"}})
5858 result
5959 end
6060
6161 it "runs a Requester with .headers as :request_options" do
6262 stub(Scraper).headers { { testheader: true } }
63− mock(Docs::Requester).run anything, satisfy { |options| options[:request_options][:headers][:testheader] }
63+ mock(Docs::Requester).run('urls', request_options: {params: {}, headers: {testheader: true}})
6464 result
6565 end
6666
6767 it "runs a Requester with default .headers as :request_options" do
68− mock(Docs::Requester).run anything, satisfy { |options| options[:request_options][:headers]["User-Agent"] }
68+ mock(Docs::Requester).run('urls', request_options: {params: {}, headers: {"User-Agent" => "DevDocs"}})
6969 result
7070 end
7171
7272 it "runs a Requester with .params as :request_options" do
7373 stub(Scraper).params { { test: true } }
74− mock(Docs::Requester).run anything, satisfy { |options| options[:request_options][:params][:test] }
74+ mock(Docs::Requester).run('urls', request_options: {params: {test: true}, headers: {"User-Agent" => "DevDocs"}})
7575 result
7676 end
7777
7878 it "runs a Requester with the given block" do
79− stub(Docs::Requester).run { |*args| @block = args.last }
79+ stub(Docs::Requester).run { |*_args, **_kwargs, &block| @block = block }
8080 result
8181 assert_equal block, @block
8282 end
test/lib/docs/core/url_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsUrlTest < MiniTest::Spec
55 URL = Docs::URL
test/lib/docs/filters/core/apply_base_url_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class ApplyBaseUrlFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/clean_html_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class CleanHtmlFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/clean_text_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class CleanTextFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/container_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class ContainerFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/entries_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class EntriesFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/inner_html_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class InnerHtmlFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/internal_urls_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class InternalUrlsFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/normalize_paths_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class NormalizePathsFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/normalize_urls_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class NormalizeUrlsFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/parse_cf_email_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class ParseCfEmailFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/filters/core/title_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../../test_helper'
2+require_relative '../../../../../lib/docs'
33
44 class TitleFilterTest < MiniTest::Spec
55 include FilterTestHelper
test/lib/docs/storage/abstract_store_test.rb+3−3
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsAbstractStoreTest < MiniTest::Spec
55 InvalidPathError = Docs::AbstractStore::InvalidPathError
@@ -368,7 +368,7 @@ class DocsAbstractStoreTest < MiniTest::Spec · 362 unmodified lines
368368 end
369369
370370 def stub_paths(*paths)
371− stub(store).each { |block| paths.each(&block) }
371+ stub(store).each { |&block| paths.each(&block) }
372372 end
373373
374374 it "calls the block" do
test/lib/docs/storage/file_store_test.rb+2−2
@@ -1,5 +1,5 @@
1−require 'test_helper'
2−require 'docs'
1+require_relative '../../../test_helper'
2+require_relative '../../../../lib/docs'
33
44 class DocsFileStoreTest < MiniTest::Spec
55 let :store do