Better error handling when cookies are disabled

Thibaut Courouble committed 10 years ago

Commit 3eb5a0c1 parent 41faea45 files · +24 −1Browse files

Unified · Split

5 files

         .install()
       @previousErrorHandler = onerror
       window.onerror = @onWindowError.bind(@)
+      CookieStore.onBlocked = @onCookieBlocked
     return
   bootOne: ->
     @quotaExceeded = true
     new app.views.Notif 'QuotaExceeded', autoHide: null
     Raven.captureMessage 'QuotaExceededError', level: 'warning'
+    return
+  onCookieBlocked: (key, value, actual) ->
+    return if @cookieBlocked
+    @cookieBlocked = true
+    new app.views.Notif 'CookieBlocked', autoHide: null
+    Raven.captureMessage "CookieBlocked/#{key}", level: 'warning', extra: {value, actual}
+    return
   onWindowError: (args...) ->
+    return if @cookieBlocked
     if @isInjectionError args...
       @onInjectionError()
     else if @isAppError args...

 class @CookieStore
   INT = /^\d+$/
+  @onBlocked: ->
   get: (key) ->
     value = Cookies.get(key)
     value = parseInt(value, 10) if value? and INT.test(value)
     value = 1 if value == true
     Cookies.set(key, '' + value, path: '/', expires: 1e8)
-    throw new Error("Failed to set cookie '#{key}'") unless @get(key) == value
+    @constructor.onBlocked(key, value, @get(key)) if @get(key) != value
     return
   del: (key) ->

@@ -23,6 +23,9 @@ app.templates.bootError = -> · 22 unmodified lines
23	If you keep seeing this, you're likely behind a proxy or firewall that blocks cross-domain requests. """	23	If you keep seeing this, you're likely behind a proxy or firewall that blocks cross-domain requests. """
24		24
25	app.templates.offlineError = (reason) ->	25	app.templates.offlineError = (reason) ->
		26	if reason is 'cookie_blocked'
		27	return error """ Cookies must be enabled to use offline mode. """
		28
26	reason = switch reason	29	reason = switch reason
27	when 'not_supported'	30	when 'not_supported'
28	""" Unfortunately your browser either doesn't support IndexedDB or does not make it available. """	31	""" Unfortunately your browser either doesn't support IndexedDB or does not make it available. """

   textNotif """ The offline database has exceeded its size limitation. """,
             """ Unfortunately this quota can't be detected programmatically, and the database can't be opened while over the quota, so it had to be reset. """
+app.templates.notifCookieBlocked = ->
+  textNotif """ Please enable cookies. """,
+            """ DevDocs will not work properly if cookies are disabled. """
 app.templates.notifInvalidLocation = ->
   textNotif """ DevDocs must be loaded from #{app.config.production_host} """,
             """ Otherwise things are likely to break. """

     return
   render: ->
+    if app.cookieBlocked
+      @html @tmpl('offlineError', 'cookie_blocked')
+      return
     app.docs.getInstallStatuses (statuses) =>
       return unless @activated
       if statuses is false