Sanity-check decaffeinate app.views.DocPicker

Simon Legner committed 2 years ago

Commit 49dbba31 parent b201fb21 file · +11 −35Browse files

Unified · Split

assets/javascripts/views/sidebar/doc_picker.js+11−35

-// TODO: This file was created by bulk-decaffeinate.
-// Sanity-check the conversion and remove this comment.
-/*
- * decaffeinate suggestions:
- * DS101: Remove unnecessary use of Array.from
- * DS102: Remove unnecessary code created because of implicit returns
- * DS103: Rewrite code to no longer use __guard__, or convert again using --optional-chaining
- * DS206: Consider reworking classes to avoid initClass
- * DS207: Consider shorter variations of null checks
- * Full docs: https://github.com/decaffeinate/decaffeinate/blob/main/docs/suggestions.md
- */
 app.views.DocPicker = class DocPicker extends app.View {
-  static initClass() {
+  static className = "_list _list-picker";
-    this.className = "_list _list-picker";
-    this.events = {
+  static events = {
-      mousedown: "onMouseDown",
+    mousedown: "onMouseDown",
-      mouseup: "onMouseUp",
+    mouseup: "onMouseUp",
-    };
+  };
-  }
   init() {
     this.addSubview((this.listFold = new app.views.ListFold(this.el)));
   render() {
     let doc;
     let html = this.tmpl("docPickerHeader");
-    let docs = app.docs
+    let docs = app.docs.all().concat(...(app.disabledDocs.all() || []));
-      .all()
-      .concat(...Array.from(app.disabledDocs.all() || []));
     while ((doc = docs.shift())) {
       if (doc.version != null) {
         var versions;
-        [docs, versions] = Array.from(this.extractVersions(docs, doc));
+        [docs, versions] = this.extractVersions(docs, doc);
         html += this.tmpl(
           "sidebarVersionedDoc",
           doc,
     this.html(html + this.tmpl("docPickerNote"));
-    $.requestAnimationFrame(() =>
+    $.requestAnimationFrame(() => this.findByTag("input")?.focus());
-      __guard__(this.findByTag("input"), (x) => x.focus()),
-    );
   }
   renderVersions(docs) {
     let html = "";
-    for (var doc of Array.from(docs)) {
+    for (var doc of docs) {
       html += this.tmpl("sidebarLabel", doc, {
         checked: app.docs.contains(doc),
       });
   extractVersions(originalDocs, version) {
     const docs = [];
     const versions = [version];
-    for (var doc of Array.from(originalDocs)) {
+    for (var doc of originalDocs) {
       (doc.name === version.name ? versions : docs).push(doc);
     }
     return [docs, versions];
   }
   getSelectedDocs() {
-    return Array.from(this.findAllByTag("input"))
+    return this.findAllByTag("input")
       .filter((input) => (input != null ? input.checked : undefined))
       .map((input) => input.name);
   }
     this.focusEl = target;
   }
 };
-app.views.DocPicker.initClass();
-function __guard__(value, transform) {
-  return typeof value !== "undefined" && value !== null
-    ? transform(value)
-    : undefined;
-}