Refactor :follow_links option

Thibaut committed 12 years ago

Commit 4a2a3931 parent bf6c9002 files · +38 −24Browse files

Unified · Split

2 files

lib/docs/filters/core/internal_urls.rb +1 −1
test/lib/docs/filters/core/internal_urls_test.rb +37 −23

lib/docs/filters/core/internal_urls.rb+1−1

@@ -20,7 +20,7 @@ module Docs · 19 unmodified lines
20	internal_urls << url.merge!(fragment: nil).to_s if internal_urls	20	internal_urls << url.merge!(fragment: nil).to_s if internal_urls
21	end	21	end
22		22
23	result[:internal_urls] = (internal_urls \|\| []).to_a	23	result[:internal_urls] = internal_urls.to_a if internal_urls
24	doc	24	doc
25	end	25	end
26		26

test/lib/docs/filters/core/internal_urls_test.rb+37−23

         assert_includes internal_urls, 'http://example.com/'
       end
     end
-    context "when context[:follow_links] is a block" do
-      before do
-        @body = link_to context[:url]
-      end
-      it "calls the block with the filter instance" do
-        context[:follow_links] = ->(arg) { @arg = arg; nil }
-        filter.call
-        assert_equal filter, @arg
-      end
-      it "is empty when the block returns false" do
-        context[:follow_links] = ->(_) { false }
-        assert_empty internal_urls
-      end
-      it "is the default when the block returns true" do
-        context[:follow_links] = ->(_) { true }
-        refute_empty internal_urls
-      end
-    end
   end
   context "when the base url is 'example.com'" do
           context[:skip_links] = ->(_) { false }
         end
-        it "set :internal_urls" do
+        it "sets :internal_urls" do
           assert internal_urls
         end
       end
     end
   end
+  context "context[:follow_links] is a block" do
+    before do
+      @body = link_to context[:url]
+    end
+    it "calls the block with the filter instance" do
+      context[:follow_links] = ->(arg) { @arg = arg; nil }
+      filter.call
+      assert_equal filter, @arg
+    end
+    context "and the block returns false" do
+      before do
+        context[:follow_links] = ->(_) { false }
+      end
+      it "doesn't set :internal_urls" do
+        refute internal_urls
+      end
+      it "replaces urls" do
+        refute_equal @body, filter_output_string
+      end
+    end
+    context "and the block returns true" do
+      before do
+        context[:follow_links] = ->(_) { true }
+      end
+      it "sets :internal_urls" do
+        assert internal_urls
+      end
+    end
+  end
 end