History

Merge pull request #1024 from jmerle/fix-openjdk-read-file

Fix OpenJDK scraper

Jasper van Merle committed 7 years ago

Commit 536003c2 parents 482d870 b31dc9d2 files · +4 −4Browse files

Unified · Split

2 files
  1. lib/docs/core/scrapers/file_scraper.rb +2 −2
  2. test/lib/docs/core/scrapers/file_scraper_test.rb +2 −2
lib/docs/core/scrapers/file_scraper.rb+2−2
@@ -29,7 +29,7 @@ module Docs · 28 unmodified lines
2929
3030 def request_one(url)
3131 assert_source_directory_exists
32− Response.new read_file(url_to_path(url)), URL.parse(url)
32+ Response.new read_file(File.join(source_directory, url_to_path(url))), URL.parse(url)
3333 end
3434
3535 def request_all(urls)
@@ -50,7 +50,7 @@ module Docs · 14 unmodified lines
5050 end
5151
5252 def read_file(path)
53− File.read(File.join(source_directory, path))
53+ File.read(path)
5454 rescue
5555 instrument 'warn.doc', msg: "Failed to open file: #{path}"
5656 nil
test/lib/docs/core/scrapers/file_scraper_test.rb+2−2
@@ -63,7 +63,7 @@ class FileScraperTest < MiniTest::Spec · 62 unmodified lines
6363 end
6464
6565 it "reads a file" do
66− mock(scraper).read_file(path)
66+ mock(scraper).read_file(File.join(ROOT_PATH, 'docs/scraper', path))
6767 result
6868 end
6969
@@ -165,7 +165,7 @@ class FileScraperTest < MiniTest::Spec · 95 unmodified lines
165165
166166 describe "#read_file" do
167167 let :result do
168− scraper.send :read_file, 'file'
168+ scraper.send :read_file, File.join(ROOT_PATH, 'docs', 'scraper', 'file')
169169 end
170170
171171 it "returns the file's content when the file exists in the source directory" do