History

Add setting to disable smooth scrolling

Thibaut Courouble committed 9 years ago

Commit 71a3c311 parent 29ec9db4 files · +23 −10Browse files

Unified · Split

4 files
  1. assets/javascripts/app/settings.coffee +0 −7
  2. assets/javascripts/templates/pages/settings_tmpl.coffee +10 −0
  3. assets/javascripts/views/content/content.coffee +4 −1
  4. assets/javascripts/views/content/settings_page.coffee +9 −2
assets/javascripts/app/settings.coffee+0−7
@@ -40,13 +40,6 @@ class app.Settings · 39 unmodified lines
40 @store.set TIPS_KEY, tips.join('/')40 @store.set TIPS_KEY, tips.join('/')
41 return41 return
42 42
43 setDark: (value) ->
44 @store.set DARK_KEY, !!value
45 return
46
47 getDark: ->
48 @store.get DARK_KEY
49
50 setLayout: (name, enable) ->43 setLayout: (name, enable) ->
51 layout = (@store.get(LAYOUT_KEY) || '').split(' ')44 layout = (@store.get(LAYOUT_KEY) || '').split(' ')
52 $.arrayDelete(layout, '')45 $.arrayDelete(layout, '')
assets/javascripts/templates/pages/settings_tmpl.coffee+10−0
@@ -17,6 +17,16 @@ app.templates.settingsPage = (settings) -> """ · 16 unmodified lines
17 </div>17 </div>
18 </div>18 </div>
19 19
20 <div class="_settings-fieldset">
21 <h2 class="_settings-legend">Scrolling:</h2>
22
23 <div class="_settings-inputs">
24 <label class="_settings-label">
25 <input type="checkbox" name="smoothScroll" value="1"#{if settings.smoothScroll then ' checked' else ''}>Use smooth scrolling
26 </label>
27 </div>
28 </div>
29
20 <div class="_settings-fieldset">30 <div class="_settings-fieldset">
21 <h2 class="_settings-legend">Advanced:</h2>31 <h2 class="_settings-legend">Advanced:</h2>
22 32
assets/javascripts/views/content/content.coffee+4−1
@@ -64,7 +64,10 @@ class app.views.Content extends app.View · 63 unmodified lines
64 return64 return
65 65
66 smoothScrollTo: (value) ->66 smoothScrollTo: (value) ->
67 $.smoothScroll @scrollEl, value or 067 if app.settings.get('fastScroll')
68 @scrollTo value
69 else
70 $.smoothScroll @scrollEl, value or 0
68 return71 return
69 72
70 scrollBy: (n) ->73 scrollBy: (n) ->
assets/javascripts/views/content/settings_page.coffee+9−2
@@ -13,7 +13,8 @@ class app.views.SettingsPage extends app.View · 12 unmodified lines
13 13
14 currentSettings: ->14 currentSettings: ->
15 settings = {}15 settings = {}
16 settings.dark = app.settings.getDark()16 settings.dark = app.settings.get('dark')
17 settings.smoothScroll = !app.settings.get('fastScroll')
17 settings[layout] = app.settings.hasLayout(layout) for layout in LAYOUTS18 settings[layout] = app.settings.hasLayout(layout) for layout in LAYOUTS
18 settings19 settings
19 20
@@ -25,7 +26,7 @@ class app.views.SettingsPage extends app.View · 5 unmodified lines
25 alt = css.getAttribute('data-alt')26 alt = css.getAttribute('data-alt')
26 css.setAttribute('data-alt', css.getAttribute('href'))27 css.setAttribute('data-alt', css.getAttribute('href'))
27 css.setAttribute('href', alt)28 css.setAttribute('href', alt)
28 app.settings.setDark(enable)29 app.settings.set('dark', !!enable)
29 app.appCache?.updateInBackground()30 app.appCache?.updateInBackground()
30 return31 return
31 32
@@ -35,6 +36,10 @@ class app.views.SettingsPage extends app.View · 3 unmodified lines
35 app.appCache?.updateInBackground()36 app.appCache?.updateInBackground()
36 return37 return
37 38
39 toggleSmoothScroll: (enable) ->
40 app.settings.set('fastScroll', !enable)
41 return
42
38 onChange: (event) =>43 onChange: (event) =>
39 input = event.target44 input = event.target
40 switch input.name45 switch input.name
@@ -42,6 +47,8 @@ class app.views.SettingsPage extends app.View · 1 unmodified line
42 @toggleDark input.checked47 @toggleDark input.checked
43 when 'layout'48 when 'layout'
44 @toggleLayout input.value, input.checked49 @toggleLayout input.value, input.checked
50 when 'smoothScroll'
51 @toggleSmoothScroll input.checked
45 return52 return
46 53
47 onRoute: (route) =>54 onRoute: (route) =>

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t