History

Cache debug.js when not running in production

Jasper van Merle committed 7 years ago

Commit 7af10a01 parent 0e9aa882 files · +3 −2Browse files

Unified · Split

2 files
  1. docs/maintainers.md +1 −1
  2. views/service-worker.js.erb +2 −1
docs/maintainers.md+1−1
@@ -84,7 +84,7 @@ In addition to the [publicly-documented commands](https://github.com/freeCodeCam · 83 unmodified lines
8484
8585 Once docs have been uploaded via `thor docs:upload` (if applicable), deploying DevDocs is as simple as running `git push heroku master`. See [Heroku's documentation](https://devcenter.heroku.com/articles/git) for more information.
8686
87−- If you're deploying documentation updates, verify that the documentations work properly once the deploy is done (you will need to reload [devdocs.io](https://devdocs.io/) a couple times for the application cache to update and the new version to load).
87+- If you're deploying documentation updates, verify that the documentations work properly once the deploy is done (you will need to reload [devdocs.io](https://devdocs.io/) a couple times for the service worker to update and the new version to load).
8888 - If you're deploying frontend changes, monitor [Sentry](https://sentry.io/devdocs/devdocs-js/) for new JS errors once the deploy is done.
8989 - If you're deploying server changes, monitor New Relic (accessible through [the Heroku dashboard](https://dashboard.heroku.com/apps/devdocs)) for Ruby exceptions and throughput or response time changes once the deploy is done.
9090
views/service-worker.js.erb+2−1
@@ -14,7 +14,8 @@ const cachePaths = [ · 13 unmodified lines
1414 '/images/webapp-icon-256.png',
1515 '/images/webapp-icon-512.png',
1616 '<%= manifest_asset_urls.join "',\n '" %>',
17− '<%= doc_index_urls.join "',\n '" %>',
17+ '<%= doc_index_urls.join "',\n '" %>',<% unless App.production? %>
18+ '<%= javascript_path('debug') %>',<% end %>
1819 ];
1920
2021 <%# Set-up the cache %>

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t