History

Tweak image max size

Thibaut Courouble committed 9 years ago

Commit 865efea1 parent 9f4cce12 files · +4 −8Browse files

Unified · Split

2 files
  1. lib/docs/filters/core/images.rb +3 −7
  2. lib/docs/subscribers/image_subscriber.rb +1 −1
lib/docs/filters/core/images.rb+3−7
@@ -4,6 +4,8 @@ module Docs · 3 unmodified lines
44 class ImagesFilter < Filter
55 include Instrumentable
66
7+ DEFAULT_MAX_SIZE = 120_000 # 120 kilobytes
8+
79 def self.optimize_image_data(data)
810 @image_optim ||= ImageOptim.new
911 @image_optim.optimize_image_data(data)
@@ -48,7 +50,7 @@ module Docs · 38 unmodified lines
4850
4951 size = image.bytesize
5052
51− if size > max_size
53+ if size > (context[:max_image_size] || DEFAULT_MAX_SIZE)
5254 instrument 'too_big.image', url: url, size: size
5355 next
5456 end
@@ -64,11 +66,5 @@ module Docs · 9 unmodified lines
6466
6567 doc
6668 end
67−
68− private
69−
70− def max_size
71− @max_size ||= context[:max_image_size] || 100.kilobytes
72− end
7369 end
7470 end
lib/docs/subscribers/image_subscriber.rb+1−1
@@ -13,7 +13,7 @@ module Docs · 12 unmodified lines
1313 end
1414
1515 def too_big(event)
16− log "Skipped large image (#{(event.payload[:size] / 1.kilobyte.to_f).round} KB): #{event.payload[:url]}"
16+ log "Skipped large image (#{(event.payload[:size] / 1_000.0).round} KB): #{event.payload[:url]}"
1717 end
1818
1919 def error(event)