Set the default FileScraper::base_url to localhost

Thibaut committed 12 years ago

Commit 9089d031 parent 5c477522 files · +25 −13Browse files

Unified · Split

2 files

     class << self
       attr_accessor :dir
+      def inherited(subclass)
+        super
+        subclass.base_url = base_url
+      end
     end
+    self.base_url = 'http://localhost/'
     private
     def request_one(url)
       Response.new read_file(file_path_for(url)), URL.parse(url)
     end
-    def request_all(start_url)
+    def request_all(url)
-      queue = [start_url]
+      queue = [url]
       until queue.empty?
         result = yield request_one(queue.shift)
         queue.concat(result) if result.is_a? Array

 class FileScraperTest < MiniTest::Spec
   class Scraper < Docs::FileScraper
-    self.dir = '/dir'
+    self.dir = '/'
-    self.base_url = 'http://example.com'
     self.html_filters = Docs::FilterStack.new
     self.text_filters = Docs::FilterStack.new
   end
     OpenStruct.new body: 'body', url: Docs::URL.parse(Scraper.base_url)
   end
+  describe ".inherited" do
+    it "sets .base_url" do
+      assert_equal Scraper.base_url, Class.new(Scraper).base_url
+    end
+  end
   describe "#request_one" do
-    let :url do
+    let :path do
-      File.join(Scraper.base_url, 'path')
+      File.join(Scraper.dir, 'path')
     end
     let :result do
-      scraper.send :request_one, url
+      scraper.send :request_one, path
     end
     before do
       stub(scraper).read_file
     end
+    it "reads a file" do
+      mock(scraper).read_file(path)
+      result
+    end
     describe "the returned response object" do
       it "has a #body" do
         stub(scraper).read_file { 'body' }
       end
       it "has a #url" do
-        assert_equal url, result.url.to_s
+        assert_equal path, result.url.to_s
         assert_instance_of Docs::URL, result.url
       end
     end
-    it "reads .dir/path when the url is .base_url/path" do
-      stub(scraper).read_file(File.join(Scraper.dir, 'path')) { 'test' }
-      assert_equal 'test', result.body
-    end
   end
   describe "#request_all" do