History

MDN browser compatibility: add Deno add Node.js

Fixes #1611. See #1655.

Simon Legner committed 4 years ago

Commit a20db441 parent dab3da01 file · +29 −4Browse files

Unified · Split

lib/docs/filters/mdn/compat_tables.rb+29−4
@@ -2,6 +2,11 @@ module Docs · 1 unmodified line
22 class Mdn
33 class CompatTablesFilter < Filter
44
5+ # Generate browser compatibility table
6+ # Fixes "BCD tables only load in the browser"
7+ # https://github.com/mdn/browser-compat-data
8+ # https://github.com/mdn/yari/tree/main/client/src/document/ingredients/browser-compatibility-table
9+
510 def call
611 if at_css('#browser_compatibility') \
712 and not at_css('#browser_compatibility').next_sibling.classes.include?('warning') \
@@ -33,6 +38,26 @@ module Docs · 25 unmodified lines
3338 'samsunginternet_android' => 'Samsung Internet'
3439 }
3540
41+ def is_javascript
42+ current_url.to_s.start_with?('https://developer.mozilla.org/en-US/docs/Web/JavaScript')
43+ end
44+
45+ def browsers
46+ if is_javascript
47+ {}.merge(BROWSERS).merge({'deno' => 'Deno', 'nodejs' => 'Node.js'})
48+ else
49+ BROWSERS
50+ end
51+ end
52+
53+ def browser_types
54+ if is_javascript
55+ {'Desktop'=>6, 'Mobile'=>6, 'Server'=>2,}
56+ else
57+ {'Desktop'=>6, 'Mobile'=>6,}
58+ end
59+ end
60+
3661 def generate_compatibility_table()
3762 json_files_uri = request_bcd_uris()
3863
@@ -88,15 +113,15 @@ module Docs · 49 unmodified lines
88113
89114 table.css('#bct-browser-type').each do |node|
90115 node.add_child('<th>')
91− %w(Desktop Mobile).each do |browser_type|
92− node.add_child("<th colspan=6>#{browser_type}")
116+ browser_types.each do |browser_type, colspan|
117+ node.add_child("<th colspan=#{colspan}>#{browser_type}")
93118 end
94119 end
95120
96121 table.css('#bct-browsers').each do |node|
97122 node.add_child('<th>')
98123
99− BROWSERS.values.each do |browser|
124+ browsers.values.each do |browser|
100125 node.add_child("<th>#{browser}")
101126 end
102127 end
@@ -119,7 +144,7 @@ module Docs · 16 unmodified lines
119144 end
120145
121146
122− BROWSERS.keys.each do |browser_key|
147+ browsers.keys.each do |browser_key|
123148 if key == '__compat'
124149 add_data_to_entry(json['support'][browser_key], last_table_entry)
125150 else