History

Simplify offline links data attributes

Thibaut committed 11 years ago

Commit be7d43e1 parent e9fc1d32 files · +7 −13Browse files

Unified · Split

2 files
  1. assets/javascripts/templates/pages/offline_tmpl.coffee +3 −3
  2. assets/javascripts/views/content/offline_page.coffee +4 −10
assets/javascripts/templates/pages/offline_tmpl.coffee+3−3
@@ -48,17 +48,17 @@ app.templates.offlineDoc = (doc, status) -> · 47 unmodified lines
4848 html += if !status.installed
4949 """
5050 <td>-</td>
51− <td><a data-dl>Install</a></td>
51+ <td><a data-action="install">Install</a></td>
5252 """
5353 else if outdated
5454 """
5555 <td>Outdated</td>
56− <td><a data-dl>Update</a> - <a data-del>Uninstall</a></td>
56+ <td><a data-action="install">Update</a> - <a data-action="uninstall">Uninstall</a></td>
5757 """
5858 else
5959 """
6060 <td>Up-to-date</td>
61− <td><a data-del>Uninstall</a></td>
61+ <td><a data-action="uninstall">Uninstall</a></td>
6262 """
6363
6464 html + '</tr>'
assets/javascripts/views/content/offline_page.coffee+4−10
@@ -39,18 +39,12 @@ class app.views.OfflinePage extends app.View · 38 unmodified lines
3939 return
4040
4141 onClick: (event) =>
42− link = event.target
43−
44− if link.hasAttribute('data-dl')
45− action = 'install'
46− else if link.hasAttribute('data-del')
47− action = 'uninstall'
48−
49− if action
42+ target = event.target
43+ if action = target.getAttribute('data-action')
5044 $.stopEvent(event)
51− doc = @docByEl(link)
45+ doc = @docByEl(target)
5246 doc[action](@onInstallSuccess.bind(@, doc), @onInstallError.bind(@, doc))
53− link.parentNode.innerHTML = "#{link.textContent.replace(/e$/, '')}ing…"
47+ target.parentNode.innerHTML = "#{target.textContent.replace(/e$/, '')}ing…"
5448 return
5549
5650 onInstallSuccess: (doc) ->