History

Improve names and types in Rust stdlib scraper…

Two main fixes: 1. Names: all pages except for modules' index pages ignored what module they were from, and were just prepended with `std::`. This meant there were 13 pages named `std::Iter`, about structs named `Iter` from different modules. It also meant that things outside modules, e.g. primitive types, were prefixed with `std::`, naming the page on `bool` as `std::bool`, although it can't be referenced that way in code. This also means that there are two pages named `std::char` - one for the module, and one for the primitive type `char`. This prefixes everything in a module with that module's path, and does not prefix primitives. It also includes submodules in the path. For example: std::fn → fn std::Iter → std::option::Iter std::MetadataExt → std::os::linux::fs::MetadataExt 2. Types: almost everything was filed in `std`, with the exception of modules' index pages and primitive types. This meant there were over 30,000 pages in the `std` type, and many types for modules with only one page in them. This creates types for each module which include all submodules, and files anything not in a module, e.g. primitive types, in `std`. For example: std::bool / std::bool → std / bool std / std::Iter → std::option / std::option::Iter std / std::MetadataExt → std::os / std::os::linux::fs::MetadataExt

Calum Smith committed 1 year ago

Commit fbb5e611 parent 18a79e11 file · +15 −8Browse files

Unified · Split

lib/docs/filters/rust/entries.rb+15−8
@@ -22,7 +22,15 @@ module Docs · 21 unmodified lines
22 else22 else
23 at_css('main h1').at_css('button')&.remove23 at_css('main h1').at_css('button')&.remove
24 name = at_css('main h1').content.remove(/\A.+\s/).remove('⎘')24 name = at_css('main h1').content.remove(/\A.+\s/).remove('⎘')
25 mod = slug.split('/').first25 path = slug.split('/')
26 if path.length == 2
27 # Anything in the standard library but not in a `std::*` module is
28 # globally available, not `use`d from the `std` crate, so we don't
29 # prepend `std::` to their name.
30 return name
31 end
32 path.pop if path.last == 'index'
33 mod = path[0..-2].join('::')
26 name.prepend("#{mod}::") unless name.start_with?(mod)34 name.prepend("#{mod}::") unless name.start_with?(mod)
27 name35 name
28 end36 end
@@ -38,13 +46,12 @@ module Docs · 9 unmodified lines
38 elsif slug.start_with?('error_codes')46 elsif slug.start_with?('error_codes')
39 'Compiler Errors'47 'Compiler Errors'
40 else48 else
41 path = name.split('::')49 path = slug.split('/')
42 heading = at_css('main h1').content.strip50 # Discard the filename, and use the first two path components as the
43 if path.length > 2 || (path.length == 2 && (heading.start_with?('Module') || heading.start_with?('Primitive')))51 # type, or one if there is only one. This means anything in a module
44 path[0..1].join('::')52 # `std::foo` or submodule `std::foo::bar` gets type `std::foo`, and
45 else53 # things not in modules, e.g. primitive types, get type `std`.
46 path[0]54 path[0..-2][0..1].join('::')
47 end
48 end55 end
49 end56 end
50 57