History

better handle null senders, trim lines after 2000

Brad Hefta-Gaub committed 9 years ago

Commit 04480231 parent f8bae602 files · +17 −5Browse files

Showing the changes to libraries/script-engine/src/ScriptEngines.cpp (1 of 2 files). Show all

Unified · Split

libraries/script-engine/src/ScriptEngines.cpp+10−5
@@ -34,27 +34,32 @@ ScriptsModel& getScriptsModel() { · 33 unmodified lines
3434
3535 void ScriptEngines::onPrintedMessage(const QString& message) {
3636 auto scriptEngine = qobject_cast<ScriptEngine*>(sender());
37− emit printedMessage(message, scriptEngine->getFilename());
37+ auto scriptName = scriptEngine ? scriptEngine->getFilename() : "";
38+ emit printedMessage(message, scriptName);
3839 }
3940
4041 void ScriptEngines::onErrorMessage(const QString& message) {
4142 auto scriptEngine = qobject_cast<ScriptEngine*>(sender());
42− emit errorMessage(message, scriptEngine->getFilename());
43+ auto scriptName = scriptEngine ? scriptEngine->getFilename() : "";
44+ emit errorMessage(message, scriptName);
4345 }
4446
4547 void ScriptEngines::onWarningMessage(const QString& message) {
4648 auto scriptEngine = qobject_cast<ScriptEngine*>(sender());
47− emit warningMessage(message, scriptEngine->getFilename());
49+ auto scriptName = scriptEngine ? scriptEngine->getFilename() : "";
50+ emit warningMessage(message, scriptName);
4851 }
4952
5053 void ScriptEngines::onInfoMessage(const QString& message) {
5154 auto scriptEngine = qobject_cast<ScriptEngine*>(sender());
52− emit infoMessage(message, scriptEngine->getFilename());
55+ auto scriptName = scriptEngine ? scriptEngine->getFilename() : "";
56+ emit infoMessage(message, scriptName);
5357 }
5458
5559 void ScriptEngines::onErrorLoadingScript(const QString& url) {
5660 auto scriptEngine = qobject_cast<ScriptEngine*>(sender());
57− emit errorLoadingScript(url, scriptEngine->getFilename());
61+ auto scriptName = scriptEngine ? scriptEngine->getFilename() : "";
62+ emit errorLoadingScript(url, scriptName);
5863 }
5964
6065 ScriptEngines::ScriptEngines()