History

Added permissions to avatar bookmarks

ksuprynowicz committed 2 years ago

Commit 076bd2d1 parent 16530b23 files · +55 −4Browse files

Showing the changes to libraries/script-engine/src/ScriptPermissions.cpp (1 of 3 files). Show all

Unified · Split

libraries/script-engine/src/ScriptPermissions.cpp+7−3
@@ -46,8 +46,12 @@ bool ScriptPermissions::isCurrentScriptAllowed(ScriptPermissions::Permission per · 45 unmodified lines
4646 // Get the script manager:
4747 auto engine = Scriptable::engine();
4848 if (!engine) {
49− qDebug() << "ScriptPermissions::isCurrentScriptAllowed called outside script engine for permission: " << scriptPermissionNames[permissionIndex];
50− return false;
49+ // When this happens it means that function was called from QML or C++ and should always be allowed
50+ if (PERMISSIONS_DEBUG_ENABLED) {
51+ qDebug() << "ScriptPermissions::isCurrentScriptAllowed called outside script engine for permission: "
52+ << scriptPermissionNames[permissionIndex];
53+ }
54+ return true;
5155 }
5256 auto manager = engine->manager();
5357 if (!manager) {
@@ -76,7 +80,7 @@ bool ScriptPermissions::isCurrentScriptAllowed(ScriptPermissions::Permission per · 22 unmodified lines
7680 }
7781 // Check if the script is allowed:
7882 QList<QString> safeURLPrefixes = { "file:///", "qrc:/", NetworkingConstants::OVERTE_COMMUNITY_APPLICATIONS,
79− NetworkingConstants::OVERTE_TUTORIAL_SCRIPTS/*, "about:console"*/};
83+ NetworkingConstants::OVERTE_TUTORIAL_SCRIPTS, "about:console"};
8084 Setting::Handle<QString> allowedURLsSetting(scriptPermissionSettingKeyNames[permissionIndex]);
8185 QList<QString> allowedURLs = allowedURLsSetting.get().split("\n");
8286