minor tweaks in response to code review (very belated) and reported issues - explicitly registering some enums with Qt at runtime (needed if they're function return values) - replaced references to engine() with local variables if they already existed

Heather Anderson committed 4 years ago

Commit 0bce0661 parent 55b5a2c5 files · +10 −5Browse files

Showing the changes to libraries/script-engine/src/qtscript/ArrayBufferClass.cpp (1 of 5 files). Show all

Unified · Split

libraries/script-engine/src/qtscript/ArrayBufferClass.cpp+1−1

@@ -86,7 +86,7 @@ QScriptValue ArrayBufferClass::newInstance(qint32 size) { · 85 unmodified lines
86	QScriptValue ArrayBufferClass::newInstance(const QByteArray& ba) {	86	QScriptValue ArrayBufferClass::newInstance(const QByteArray& ba) {
87	QScriptEngine* eng = engine();	87	QScriptEngine* eng = engine();
88	QScriptValue data = eng->newVariant(QVariant::fromValue(ba));	88	QScriptValue data = eng->newVariant(QVariant::fromValue(ba));
89	return engine()->newObject(this, data);	89	return eng->newObject(this, data);
90	}	90	}
91		91
92	QScriptValue ArrayBufferClass::construct(QScriptContext* context, QScriptEngine* engine) {	92	QScriptValue ArrayBufferClass::construct(QScriptContext* context, QScriptEngine* engine) {