History

Add V8 logging category

Rename logging category to overte Make all V8 code use logging categories

Dale Glass committed 3 years ago

Commit 0fc2ab81 parent 633319c10 files · +211 −161Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptContextV8Wrapper.cpp (1 of 10 files). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptContextV8Wrapper.cpp+3−1
@@ -16,6 +16,8 @@ · 15 unmodified lines
16 16
17#include "ScriptEngineV8.h"17#include "ScriptEngineV8.h"
18#include "ScriptValueV8Wrapper.h"18#include "ScriptValueV8Wrapper.h"
19#include "ScriptEngineLoggingV8.h"
20
19 21
20/*ScriptContextV8Wrapper::ScriptContextV8Wrapper(ScriptEngineV8* engine, const v8::Local<v8::Context> context) : _functionCallbackInfo(nullptr), _propertyCallbackInfo(nullptr), _engine(engine) {22/*ScriptContextV8Wrapper::ScriptContextV8Wrapper(ScriptEngineV8* engine, const v8::Local<v8::Context> context) : _functionCallbackInfo(nullptr), _propertyCallbackInfo(nullptr), _engine(engine) {
21 _context.Reset(_engine->getIsolate(), context);23 _context.Reset(_engine->getIsolate(), context);
@@ -178,7 +180,7 @@ ScriptValue ScriptContextV8Wrapper::throwError(const QString& text) { · 156 unmodified lines
178 v8::String::NewFromUtf8(_engine->getIsolate(), text.toStdString().c_str()).ToLocalChecked()));180 v8::String::NewFromUtf8(_engine->getIsolate(), text.toStdString().c_str()).ToLocalChecked()));
179 return ScriptValue(new ScriptValueV8Wrapper(_engine, std::move(result)));181 return ScriptValue(new ScriptValueV8Wrapper(_engine, std::move(result)));
180 } else {182 } else {
181 qWarning() << "throwError on a different thread not implemented yet, error value: " << text;183 qCWarning(scriptengine_v8) << "throwError on a different thread not implemented yet, error value: " << text;
182 //return _engine->undefinedValue();184 //return _engine->undefinedValue();
183 return ScriptValue();185 return ScriptValue();
184 }186 }

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t