History

Adding some fixmes to the code, since globals are evil and such checks should be confined to debug mode only

Brad Davis committed 11 years ago

Commit 16622301 parent e6163081 file · +3 −1Browse files

Showing the changes to interface/src/Application.cpp (1 of 1 file). Show all

Unified · Split

interface/src/Application.cpp+3−1
@@ -2795,11 +2795,12 @@ QImage Application::renderAvatarBillboard() { · 2794 unmodified lines
27952795 return image;
27962796 }
27972797
2798−
2798+// FIXME, preprocessor guard this check to occur only in DEBUG builds
27992799 static QThread * activeRenderingThread = nullptr;
28002800
28012801 ViewFrustum* Application::getViewFrustum() {
28022802 if (QThread::currentThread() == activeRenderingThread) {
2803+ // FIXME, should this be an assert?
28032804 qWarning() << "Calling Application::getViewFrustum() from the active rendering thread, did you mean Application::getDisplayViewFrustum()?";
28042805 }
28052806 return &_viewFrustum;
@@ -2807,6 +2808,7 @@ ViewFrustum* Application::getViewFrustum() { · 1 unmodified line
28072808
28082809 ViewFrustum* Application::getDisplayViewFrustum() {
28092810 if (QThread::currentThread() != activeRenderingThread) {
2811+ // FIXME, should this be an assert?
28102812 qWarning() << "Calling Application::getDisplayViewFrustum() from outside the active rendering thread or outside rendering, did you mean Application::getViewFrustum()?";
28112813 }
28122814 return &_displayViewFrustum;