History

Revert "Initial check that the script url has a supported extension, currently JS only"

This reverts commit d50bdd6aa9c8557b92609497ff50dac5231dbcf1.

Liv committed 9 years ago

Commit 1fa3e6b1 parent 0e6f3e21 file · +1 −6Browse files

Showing the changes to libraries/script-engine/src/ScriptEngines.cpp (1 of 1 file). Show all

Unified · Split

libraries/script-engine/src/ScriptEngines.cpp+1−6
@@ -9,7 +9,6 @@ · 8 unmodified lines
99 #include "ScriptEngines.h"
1010
1111 #include <QtCore/QStandardPaths>
12−#include <QtCore/QFileInfo>
1312
1413 #include <QtWidgets/QApplication>
1514
@@ -450,7 +449,6 @@ ScriptEngine* ScriptEngines::loadScript(const QUrl& scriptFilename, bool isUserL · 434 unmodified lines
450449 return result;
451450 }
452451 QUrl scriptUrl;
453−
454452 if (!scriptFilename.isValid() ||
455453 (scriptFilename.scheme() != "http" &&
456454 scriptFilename.scheme() != "https" &&
@@ -474,11 +472,8 @@ ScriptEngine* ScriptEngines::loadScript(const QUrl& scriptFilename, bool isUserL · 17 unmodified lines
474472 scriptEngine->deleteLater();
475473 }, Qt::QueuedConnection);
476474
477− // Check that the script is actually a script
478− QFileInfo fileInfo(scriptFilename.toString());
479− bool hasValidScriptSuffix = (fileInfo.completeSuffix() == "js");
480475
481− if (scriptFilename.isEmpty() || !scriptUrl.isValid() || !hasValidScriptSuffix) {
476+ if (scriptFilename.isEmpty() || !scriptUrl.isValid()) {
482477 launchScriptEngine(scriptEngine);
483478 } else {
484479 // connect to the appropriate signals of this script engine

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t