History

More work on menus and some code cleanup

Brad Davis committed 11 years ago

Commit 1ff8c671 parent c0d562e21 files · +437 −512Browse files

Showing the changes to interface/src/scripting/MenuScriptingInterface.cpp (1 of 21 files). Show all

Unified · Split

interface/src/scripting/MenuScriptingInterface.cpp+13−35
@@ -28,72 +28,50 @@ void MenuScriptingInterface::menuItemTriggered() { · 27 unmodified lines
2828 }
2929
3030 void MenuScriptingInterface::addMenu(const QString& menu) {
31− QMetaObject::invokeMethod(Menu::getInstance(), "addMenu", Q_ARG(const QString&, menu));
31+ Menu::getInstance()->addMenu("", menu);
3232 }
3333
3434 void MenuScriptingInterface::removeMenu(const QString& menu) {
35− QMetaObject::invokeMethod(Menu::getInstance(), "removeMenu", Q_ARG(const QString&, menu));
35+ Menu::getInstance()->removeMenu(menu);
3636 }
3737
3838 bool MenuScriptingInterface::menuExists(const QString& menu) {
39− bool result;
40− QMetaObject::invokeMethod(Menu::getInstance(), "menuExists", Qt::BlockingQueuedConnection,
41− Q_RETURN_ARG(bool, result),
42− Q_ARG(const QString&, menu));
43− return result;
39+ return Menu::getInstance()->menuExists(menu);
4440 }
4541
4642 void MenuScriptingInterface::addSeparator(const QString& menuName, const QString& separatorName) {
47− QMetaObject::invokeMethod(Menu::getInstance(), "addSeparator",
48− Q_ARG(const QString&, menuName),
49− Q_ARG(const QString&, separatorName));
43+ Menu::getInstance()->addSeparator(menuName, separatorName);
5044 }
5145
5246 void MenuScriptingInterface::removeSeparator(const QString& menuName, const QString& separatorName) {
53− QMetaObject::invokeMethod(Menu::getInstance(), "removeSeparator",
54− Q_ARG(const QString&, menuName),
55− Q_ARG(const QString&, separatorName));
47+ Menu::getInstance()->removeSeparator(menuName, separatorName);
5648 }
5749
5850 void MenuScriptingInterface::addMenuItem(const MenuItemProperties& properties) {
59− QMetaObject::invokeMethod(Menu::getInstance(), "addMenuItem", Q_ARG(const MenuItemProperties&, properties));
51+ Menu::getInstance()->addMenuItem(properties);
6052 }
6153
6254 void MenuScriptingInterface::addMenuItem(const QString& menu, const QString& menuitem, const QString& shortcutKey) {
63− MenuItemProperties properties(menu, menuitem, shortcutKey);
64− QMetaObject::invokeMethod(Menu::getInstance(), "addMenuItem", Q_ARG(const MenuItemProperties&, properties));
55+ Menu::getInstance()->addItem(menu, menuitem);
56+ Menu::getInstance()->setItemShortcut(menuitem, shortcutKey);
6557 }
6658
6759 void MenuScriptingInterface::addMenuItem(const QString& menu, const QString& menuitem) {
68− MenuItemProperties properties(menu, menuitem);
69− QMetaObject::invokeMethod(Menu::getInstance(), "addMenuItem", Q_ARG(const MenuItemProperties&, properties));
60+ Menu::getInstance()->addItem(menu, menuitem);
7061 }
7162
7263 void MenuScriptingInterface::removeMenuItem(const QString& menu, const QString& menuitem) {
73− QMetaObject::invokeMethod(Menu::getInstance(), "removeMenuItem",
74− Q_ARG(const QString&, menu),
75− Q_ARG(const QString&, menuitem));
64+ Menu::getInstance()->removeItem(menuitem);
7665 };
7766
7867 bool MenuScriptingInterface::menuItemExists(const QString& menu, const QString& menuitem) {
79− bool result;
80− QMetaObject::invokeMethod(Menu::getInstance(), "menuItemExists", Qt::BlockingQueuedConnection,
81− Q_RETURN_ARG(bool, result),
82− Q_ARG(const QString&, menu),
83− Q_ARG(const QString&, menuitem));
84− return result;
68+ return Menu::getInstance()->itemExists(menu, menuitem);
8569 }
8670
8771 bool MenuScriptingInterface::isOptionChecked(const QString& menuOption) {
88− bool result;
89− QMetaObject::invokeMethod(Menu::getInstance(), "isOptionChecked", Qt::BlockingQueuedConnection,
90− Q_RETURN_ARG(bool, result),
91− Q_ARG(const QString&, menuOption));
92− return result;
72+ return Menu::getInstance()->isChecked(menuOption);
9373 }
9474
9575 void MenuScriptingInterface::setIsOptionChecked(const QString& menuOption, bool isChecked) {
96− QMetaObject::invokeMethod(Menu::getInstance(), "setIsOptionChecked", Qt::BlockingQueuedConnection,
97− Q_ARG(const QString&, menuOption),
98− Q_ARG(bool, isChecked));
76+ Menu::getInstance()->setChecked(menuOption, isChecked);
9977 }