History

Rename wait and unload in best thread

Zach Pomerantz committed 10 years ago

Commit 2140dc71 parent 806d06b4 files · +13 −15Browse files

Showing the changes to libraries/script-engine/src/ScriptEngines.cpp (1 of 4 files). Show all

Unified · Split

libraries/script-engine/src/ScriptEngines.cpp+1−4
@@ -158,9 +158,6 @@ void ScriptEngines::shutdownScripting() { · 157 unmodified lines
158 // and stop. We can safely short circuit this because we know we're in the "quitting" process158 // and stop. We can safely short circuit this because we know we're in the "quitting" process
159 scriptEngine->disconnect(this);159 scriptEngine->disconnect(this);
160 160
161 // If this is an entity script, we need to unload any entities
162 scriptEngine->unloadAllEntityScripts();
163
164 // Gracefully stop the engine's scripting thread161 // Gracefully stop the engine's scripting thread
165 scriptEngine->stop();162 scriptEngine->stop();
166 163
@@ -168,7 +165,7 @@ void ScriptEngines::shutdownScripting() { · 1 unmodified line
168 // want any of the scripts final "scriptEnding()" or pending "update()" methods from accessing165 // want any of the scripts final "scriptEnding()" or pending "update()" methods from accessing
169 // any application state after we leave this stopAllScripts() method166 // any application state after we leave this stopAllScripts() method
170 qCDebug(scriptengine) << "waiting on script:" << scriptName;167 qCDebug(scriptengine) << "waiting on script:" << scriptName;
171 scriptEngine->wait();168 scriptEngine->waitTillDoneRunning();
172 qCDebug(scriptengine) << "done waiting on script:" << scriptName;169 qCDebug(scriptengine) << "done waiting on script:" << scriptName;
173 170
174 scriptEngine->deleteLater();171 scriptEngine->deleteLater();