History

Merge pull request #2939 from huffman/19648

Code Review for Job #19648

AndrewMeadows committed 12 years ago

Commit 21f045e2 parents 7940544 425632e11 files · +640 −10Browse files

Showing the changes to interface/src/Application.cpp (1 of 11 files). Show all

Unified · Split

interface/src/Application.cpp+14−9
@@ -3254,16 +3254,21 @@ ScriptEngine* Application::loadScript(const QString& scriptName, bool loadScript · 3253 unmodified lines
32543254 return _scriptEnginesHash[scriptName];
32553255 }
32563256
3257− // start the script on a new thread...
3258− QUrl scriptUrl(scriptName);
3259− ScriptEngine* scriptEngine = new ScriptEngine(scriptUrl, &_controllerScriptingInterface);
3260− _scriptEnginesHash.insert(scriptUrl.toString(), scriptEngine);
3261−
3262− if (!scriptEngine->hasScript()) {
3263− qDebug() << "Application::loadScript(), script failed to load...";
3264− return NULL;
3257+ ScriptEngine* scriptEngine;
3258+ if (scriptName.isNull()) {
3259+ scriptEngine = new ScriptEngine(NO_SCRIPT, "", &_controllerScriptingInterface);
3260+ } else {
3261+ // start the script on a new thread...
3262+ QUrl scriptUrl(scriptName);
3263+ scriptEngine = new ScriptEngine(scriptUrl, &_controllerScriptingInterface);
3264+ _scriptEnginesHash.insert(scriptName, scriptEngine);
3265+
3266+ if (!scriptEngine->hasScript()) {
3267+ qDebug() << "Application::loadScript(), script failed to load...";
3268+ return NULL;
3269+ }
3270+ _runningScriptsWidget->setRunningScripts(getRunningScripts());
32653271 }
3266− _runningScriptsWidget->setRunningScripts(getRunningScripts());
32673272
32683273 // setup the packet senders and jurisdiction listeners of the script engine's scripting interfaces so
32693274 // we can use the same ones from the application.

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t