History

more code review using github compiler runs

Heather Anderson committed 5 years ago

Commit 227e8991 parent 16c2d7618 files · +100 −36Browse files

Showing the changes to libraries/script-engine/src/ScriptValue.cpp (1 of 18 files). Show all

Unified · Split

libraries/script-engine/src/ScriptValue.cpp+2−2
@@ -14,7 +14,7 @@ · 13 unmodified lines
14#include "ScriptEngineLogging.h"14#include "ScriptEngineLogging.h"
15 15
16 16
17class ScriptValueProxyNull : public ScriptValueProxy {17class ScriptValueProxyNull final : public ScriptValueProxy {
18public:18public:
19 virtual void release() override;19 virtual void release() override;
20 virtual ScriptValueProxy* copy() const override;20 virtual ScriptValueProxy* copy() const override;
@@ -43,7 +43,7 @@ public: · 22 unmodified lines
43 const ScriptValue::ResolveFlags& mode = ScriptValue::ResolvePrototype) const override;43 const ScriptValue::ResolveFlags& mode = ScriptValue::ResolvePrototype) const override;
44 virtual ScriptValue property(quint32 arrayIndex,44 virtual ScriptValue property(quint32 arrayIndex,
45 const ScriptValue::ResolveFlags& mode = ScriptValue::ResolvePrototype) const override;45 const ScriptValue::ResolveFlags& mode = ScriptValue::ResolvePrototype) const override;
46 virtual void setData(const ScriptValue& val);46 virtual void setData(const ScriptValue& val) override;
47 virtual void setProperty(const QString& name,47 virtual void setProperty(const QString& name,
48 const ScriptValue& value,48 const ScriptValue& value,
49 const ScriptValue::PropertyFlags& flags = ScriptValue::KeepExistingFlags) override;49 const ScriptValue::PropertyFlags& flags = ScriptValue::KeepExistingFlags) override;