History

more code review using github compiler runs

Heather Anderson committed 5 years ago

Commit 227e8991 parent 16c2d7618 files · +100 −36Browse files

Showing the changes to libraries/script-engine/src/ScriptProgram.h (1 of 18 files). Show all

Unified · Split

libraries/script-engine/src/ScriptProgram.h+6−0
@@ -28,6 +28,9 @@ public: · 27 unmodified lines
2828 virtual ScriptSyntaxCheckResultPointer checkSyntax() const = 0;
2929 virtual QString fileName() const = 0;
3030 virtual QString sourceCode() const = 0;
31+
32+protected:
33+ ~ScriptProgram() {} // prevent explicit deletion of base class
3134 };
3235
3336 /// [ScriptInterface] Provides an engine-independent interface for QScriptSyntaxCheckResult
@@ -45,6 +48,9 @@ public: · 11 unmodified lines
4548 virtual int errorLineNumber() const = 0;
4649 virtual QString errorMessage() const = 0;
4750 virtual State state() const = 0;
51+
52+protected:
53+ ~ScriptSyntaxCheckResult() {} // prevent explicit deletion of base class
4854 };
4955
5056 #endif // hifi_ScriptProgram_h

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t