more code review using github compiler runs

Heather Anderson committed 5 years ago

Commit 227e8991 parent 16c2d7618 files · +100 −36Browse files

Showing the changes to libraries/script-engine/src/ScriptValue.cpp (1 of 18 files). Show all

Unified · Split

libraries/script-engine/src/ScriptValue.cpp+2−2

@@ -14,7 +14,7 @@ · 13 unmodified lines
14	14	#include "ScriptEngineLogging.h"
15	15
16	16
17		−class ScriptValueProxyNull : public ScriptValueProxy {
	17	+class ScriptValueProxyNull final : public ScriptValueProxy {
18	18	public:
19	19	virtual void release() override;
20	20	virtual ScriptValueProxy* copy() const override;
@@ -43,7 +43,7 @@ public: · 22 unmodified lines
43	43	const ScriptValue::ResolveFlags& mode = ScriptValue::ResolvePrototype) const override;
44	44	virtual ScriptValue property(quint32 arrayIndex,
45	45	const ScriptValue::ResolveFlags& mode = ScriptValue::ResolvePrototype) const override;
46		− virtual void setData(const ScriptValue& val);
	46	+ virtual void setData(const ScriptValue& val) override;
47	47	virtual void setProperty(const QString& name,
48	48	const ScriptValue& value,
49	49	const ScriptValue::PropertyFlags& flags = ScriptValue::KeepExistingFlags) override;