History

Made changes requested by reviewer

Fixed missing copyright headers. Fixed exceeding 120 columns. Fixed #include Fixed if conditional style. Fixed C++ reference symbol placement.

Marcus Llewellyn committed 6 years ago

Commit 24669c91 parent f23dfc74 files · +102 −32Browse files

Showing the changes to plugins/opusCodec/src/OpusDecoder.cpp (1 of 4 files). Show all

Unified · Split

plugins/opusCodec/src/OpusDecoder.cpp+30−10
@@ -1,3 +1,13 @@
1+//
2+// OpusCodecManager.h
3+// plugins/opusCodec/src
4+//
5+// Copyright 2020 Dale Glass
6+//
7+// Distributed under the Apache License, Version 2.0.
8+// See the accompanying file LICENSE or http://www.apache.org/licenses/LICENSE-2.0.html
9+//
10+
111 #include <PerfStat.h>
212 #include <QtCore/QLoggingCategory>
313 #include <AudioConstants.h>
@@ -60,25 +70,30 @@ void AthenaOpusDecoder::decode(const QByteArray &encodedBuffer, QByteArray &deco · 56 unmodified lines
6070 PerformanceTimer perfTimer("AthenaOpusDecoder::decode");
6171
6272 // The audio system encodes and decodes always in fixed size chunks
63− int buffer_size = AudioConstants::NETWORK_FRAME_SAMPLES_PER_CHANNEL * static_cast<int>(sizeof(int16_t)) * _opus_num_channels;
73+ int buffer_size = AudioConstants::NETWORK_FRAME_SAMPLES_PER_CHANNEL * static_cast<int>(sizeof(int16_t))
74+ * _opus_num_channels;
6475
6576 decodedBuffer.resize( buffer_size );
6677 int buffer_frames = decodedBuffer.size() / _opus_num_channels / static_cast<int>(sizeof( opus_int16 ));
6778
68− qCDebug(decoder) << "Opus decode: encodedBytes = " << encodedBuffer.length() << "; decodedBufferBytes = " << decodedBuffer.size() << "; frameCount = " << buffer_frames;
69− int decoded_frames = opus_decode( _decoder, reinterpret_cast<const unsigned char*>(encodedBuffer.data()), encodedBuffer.length(), reinterpret_cast<opus_int16*>(decodedBuffer.data()), buffer_frames, 0 );
79+ qCDebug(decoder) << "Opus decode: encodedBytes = " << encodedBuffer.length() << "; decodedBufferBytes = "
80+ << decodedBuffer.size() << "; frameCount = " << buffer_frames;
81+ int decoded_frames = opus_decode( _decoder, reinterpret_cast<const unsigned char*>(encodedBuffer.data()),
82+ encodedBuffer.length(), reinterpret_cast<opus_int16*>(decodedBuffer.data()), buffer_frames, 0 );
7083
7184 if ( decoded_frames >= 0 ) {
7285 //qCDebug(decoder) << "Decoded " << decoded_frames << " Opus frames, " << buffer_frames << " expected";
7386
7487 if ( decoded_frames < buffer_frames ) {
75− qCWarning(decoder) << "Opus decoder returned " << decoded_frames << ", but " << buffer_frames << " were expected!";
88+ qCWarning(decoder) << "Opus decoder returned " << decoded_frames << ", but " << buffer_frames
89+ << " were expected!";
7690
7791 int start = decoded_frames * static_cast<int>(sizeof(int16_t)) * _opus_num_channels;
7892 memset( &decodedBuffer.data()[start], 0, static_cast<size_t>(decodedBuffer.length() - start));
7993 } else if ( decoded_frames > buffer_frames ) {
8094 // This should never happen
81− qCCritical(decoder) << "Opus decoder returned " << decoded_frames << ", but only " << buffer_frames << " were expected! Buffer overflow!?";
95+ qCCritical(decoder) << "Opus decoder returned " << decoded_frames << ", but only " << buffer_frames
96+ << " were expected! Buffer overflow!?";
8297 }
8398 } else {
8499 qCCritical(decoder) << "Failed to decode audio: " << error_to_string(decoded_frames);
@@ -93,23 +108,28 @@ void AthenaOpusDecoder::lostFrame(QByteArray &decodedBuffer) · 8 unmodified lines
93108
94109 PerformanceTimer perfTimer("AthenaOpusDecoder::lostFrame");
95110
96− int buffer_size = AudioConstants::NETWORK_FRAME_SAMPLES_PER_CHANNEL * static_cast<int>(sizeof(int16_t)) * _opus_num_channels;
111+ int buffer_size = AudioConstants::NETWORK_FRAME_SAMPLES_PER_CHANNEL * static_cast<int>(sizeof(int16_t))
112+ * _opus_num_channels;
97113 decodedBuffer.resize( buffer_size );
98114 int buffer_frames = decodedBuffer.size() / _opus_num_channels / static_cast<int>(sizeof( opus_int16 ));
99115
100− int decoded_frames = opus_decode( _decoder, nullptr, 0, reinterpret_cast<opus_int16*>(decodedBuffer.data()), buffer_frames, 1 );
116+ int decoded_frames = opus_decode( _decoder, nullptr, 0, reinterpret_cast<opus_int16*>(decodedBuffer.data()),
117+ buffer_frames, 1 );
101118
102119 if ( decoded_frames >= 0 ) {
103− //qCDebug(decoder) << "Produced " << decoded_frames << " opus frames from a lost frame, " << buffer_frames << " expected";
120+ //qCDebug(decoder) << "Produced " << decoded_frames << " opus frames from a lost frame, " << buffer_frames
121+ // << " expected";
104122
105123 if ( decoded_frames < buffer_frames ) {
106− qCWarning(decoder) << "Opus decoder returned " << decoded_frames << ", but " << buffer_frames << " were expected!";
124+ qCWarning(decoder) << "Opus decoder returned " << decoded_frames << ", but " << buffer_frames
125+ << " were expected!";
107126
108127 int start = decoded_frames * static_cast<int>(sizeof(int16_t)) * _opus_num_channels;
109128 memset( &decodedBuffer.data()[start], 0, static_cast<size_t>(decodedBuffer.length() - start));
110129 } else if ( decoded_frames > buffer_frames ) {
111130 // This should never happen
112− qCCritical(decoder) << "Opus decoder returned " << decoded_frames << ", but only " << buffer_frames << " were expected! Buffer overflow!?";
131+ qCCritical(decoder) << "Opus decoder returned " << decoded_frames << ", but only " << buffer_frames
132+ << " were expected! Buffer overflow!?";
113133 }
114134 } else {
115135 qCCritical(decoder) << "Failed to decode lost frame: " << error_to_string(decoded_frames);