History

Revert "AnimPose operator* optimizations"

This reverts commit 569bef50fdaea8b51abf14c8ed9afc935c84ed16.

Anthony Thibault committed 7 years ago

Commit 39b4eaa1 parent f0e163b17 files · +81 −148Browse files

Showing the changes to libraries/render-utils/src/AnimDebugDraw.cpp (1 of 17 files). Show all

Unified · Split

libraries/render-utils/src/AnimDebugDraw.cpp+4−4
@@ -374,7 +374,7 @@ void AnimDebugDraw::update() { · 373 unmodified lines
374374 glm::vec4 color = std::get<3>(iter.second);
375375
376376 for (int i = 0; i < skeleton->getNumJoints(); i++) {
377− const float radius = BONE_RADIUS / (absPoses[i].scale() * rootPose.scale());
377+ const float radius = BONE_RADIUS / (absPoses[i].scale().x * rootPose.scale().x);
378378
379379 // draw bone
380380 addBone(rootPose, absPoses[i], radius, color, v);
@@ -394,16 +394,16 @@ void AnimDebugDraw::update() { · 13 unmodified lines
394394 glm::vec3 pos = std::get<1>(iter.second);
395395 glm::vec4 color = std::get<2>(iter.second);
396396 const float radius = POSE_RADIUS;
397− addBone(AnimPose::identity, AnimPose(1.0f, rot, pos), radius, color, v);
397+ addBone(AnimPose::identity, AnimPose(glm::vec3(1), rot, pos), radius, color, v);
398398 }
399399
400− AnimPose myAvatarPose(1.0f, DebugDraw::getInstance().getMyAvatarRot(), DebugDraw::getInstance().getMyAvatarPos());
400+ AnimPose myAvatarPose(glm::vec3(1), DebugDraw::getInstance().getMyAvatarRot(), DebugDraw::getInstance().getMyAvatarPos());
401401 for (auto& iter : myAvatarMarkerMap) {
402402 glm::quat rot = std::get<0>(iter.second);
403403 glm::vec3 pos = std::get<1>(iter.second);
404404 glm::vec4 color = std::get<2>(iter.second);
405405 const float radius = POSE_RADIUS;
406− addBone(myAvatarPose, AnimPose(1.0f, rot, pos), radius, color, v);
406+ addBone(myAvatarPose, AnimPose(glm::vec3(1), rot, pos), radius, color, v);
407407 }
408408
409409 // draw rays from shared DebugDraw singleton

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t