History

V8-related cleanup

ksuprynowicz committed 3 years ago

Commit 3c804111 parent 30f460814 files · +5 −62Browse files

Showing the changes to libraries/script-engine/src/ScriptValueUtils.cpp (1 of 14 files). Show all

Unified · Split

libraries/script-engine/src/ScriptValueUtils.cpp+1−1
@@ -282,7 +282,7 @@ bool vec3FromScriptValue(const ScriptValue& object, glm::vec3& vec3) { · 281 unmodified lines
282282 }
283283
284284 if (!x.isValid() || !y.isValid() || !z.isValid()) {
285− // V8TODO: This breaks the sit script for some reason
285+ // V8TODO: This breaks the sit script because in our API valid Vec3 can be created from just 2 values
286286 //return false;
287287 }
288288