History

Updated whitelist debugs for clarity in dev log

Kasen IO committed 6 years ago

Commit 3e6660b1 parent 2de388a1 file · +4 −3Browse files

Showing the changes to libraries/script-engine/src/ScriptEngine.cpp (1 of 1 file). Show all

Unified · Split

libraries/script-engine/src/ScriptEngine.cpp+4−3
@@ -2364,6 +2364,7 @@ void ScriptEngine::entityScriptContentAvailable(const EntityItemID& entityID, co · 2363 unmodified lines
23642364 }
23652365 else {
23662366 // ENTITY SCRIPT WHITELIST STARTS HERE
2367+ QString whitelistPrefix = "[WHITELIST ENTITY SCRIPTS]";
23672368 QList<QString> safeURLS = { "" };
23682369 safeURLS += qEnvironmentVariable("EXTRA_WHITELIST").trimmed().split(QRegExp("\\s*,\\s*"), QString::SkipEmptyParts);
23692370
@@ -2377,16 +2378,16 @@ void ScriptEngine::entityScriptContentAvailable(const EntityItemID& entityID, co · 7 unmodified lines
23772378
23782379 bool isInWhitelist = false; // assume unsafe
23792380 for (const auto& str : safeURLS) {
2380− qCDebug(scriptengine) << "Script URL: " << scriptOrURL << "TESTING AGAINST" << str << "RESULTS IN"
2381+ qCDebug(scriptengine) << whitelistPrefix << "Script URL: " << scriptOrURL << "TESTING AGAINST" << str << "RESULTS IN"
23812382 << scriptOrURL.startsWith(str);
23822383 if (!str.isEmpty() && scriptOrURL.startsWith(str)) {
23832384 isInWhitelist = true;
2384− qCDebug(scriptengine) << "Script approved.";
2385+ qCDebug(scriptengine) << whitelistPrefix << "Script approved.";
23852386 break; // bail early since we found a match
23862387 }
23872388 }
23882389 if (!isInWhitelist) {
2389− qCDebug(scriptengine) << "(disabled entity script)" << entityID.toString() << scriptOrURL;
2390+ qCDebug(scriptengine) << whitelistPrefix << "(disabled entity script)" << entityID.toString() << scriptOrURL;
23902391 exception = makeError("UNSAFE_ENTITY_SCRIPTS == 0");
23912392 } else {
23922393 QTimer timeout;