WL 21664 - Window.innerHeight should not include the menu bar

Cain Kilgore committed 8 years ago

Commit 47038e41 parent c33c6372 files · +13 −6Browse files

Showing the changes to interface/src/scripting/WindowScriptingInterface.cpp (1 of 2 files). Show all

Unified · Split

     return offscreenUi->isPointOnDesktopWindow(point);
 }
-glm::vec2 WindowScriptingInterface::getDeviceSize() const {
-    return qApp->getDeviceSize();
-}
 /// Makes sure that the reticle is visible, use this in blocking forms that require a reticle and
 /// might be in same thread as a script that sets the reticle to invisible
 void WindowScriptingInterface::ensureReticleVisible() const {
 }
 int WindowScriptingInterface::getInnerWidth() {
-    return qApp->getWindow()->geometry().width();
+    return qApp->getDeviceSize().x;
 }
 int WindowScriptingInterface::getInnerHeight() {
-    return qApp->getWindow()->geometry().height();
+    return qApp->getDeviceSize().y;
+}
+int WindowScriptingInterface::getMenuHeight() {
+    return qApp->getPrimaryMenu()->geometry().height();
+}
+glm::vec2 WindowScriptingInterface::getDeviceSize() const {
+    return qApp->getDeviceSize();
 }
 int WindowScriptingInterface::getX() {