History

WL 21664 - Window.innerHeight should not include the menu bar

Cain Kilgore committed 8 years ago

Commit 47038e41 parent c33c6372 files · +13 −6Browse files

Showing the changes to interface/src/scripting/WindowScriptingInterface.cpp (1 of 2 files). Show all

Unified · Split

interface/src/scripting/WindowScriptingInterface.cpp+10−6
@@ -176,10 +176,6 @@ bool WindowScriptingInterface::isPointOnDesktopWindow(QVariant point) { · 175 unmodified lines
176176 return offscreenUi->isPointOnDesktopWindow(point);
177177 }
178178
179−glm::vec2 WindowScriptingInterface::getDeviceSize() const {
180− return qApp->getDeviceSize();
181−}
182−
183179 /// Makes sure that the reticle is visible, use this in blocking forms that require a reticle and
184180 /// might be in same thread as a script that sets the reticle to invisible
185181 void WindowScriptingInterface::ensureReticleVisible() const {
@@ -391,11 +387,19 @@ QString WindowScriptingInterface::checkVersion() { · 205 unmodified lines
391387 }
392388
393389 int WindowScriptingInterface::getInnerWidth() {
394− return qApp->getWindow()->geometry().width();
390+ return qApp->getDeviceSize().x;
395391 }
396392
397393 int WindowScriptingInterface::getInnerHeight() {
398− return qApp->getWindow()->geometry().height();
394+ return qApp->getDeviceSize().y;
395+}
396+
397+int WindowScriptingInterface::getMenuHeight() {
398+ return qApp->getPrimaryMenu()->geometry().height();
399+}
400+
401+glm::vec2 WindowScriptingInterface::getDeviceSize() const {
402+ return qApp->getDeviceSize();
399403 }
400404
401405 int WindowScriptingInterface::getX() {