History

Move ExternalResource call into method

Fixes Interface crash on Windows.

David Rowe committed 6 years ago

Commit 4959ca41 parent 3344c741 file · +5 −2Browse files

Showing the changes to interface/src/scripting/ScreenshareScriptingInterface.cpp (1 of 1 file). Show all

Unified · Split

interface/src/scripting/ScreenshareScriptingInterface.cpp+5−2
@@ -130,8 +130,9 @@ static const uint8_t LOCAL_SCREENSHARE_WEB_ENTITY_FPS = 30; · 129 unmodified lines
130130 // The `z` value here is dynamic.
131131 static const glm::vec3 LOCAL_SCREENSHARE_WEB_ENTITY_LOCAL_POSITION(0.0128f, -0.0918f, 0.0f);
132132 static const glm::vec3 LOCAL_SCREENSHARE_WEB_ENTITY_DIMENSIONS(3.6790f, 2.0990f, 0.0100f);
133−static const QString LOCAL_SCREENSHARE_WEB_ENTITY_URL = ExternalResource::getInstance()->getUrl(ExternalResource::Bucket::HF_Content,
134− "Experiences/Releases/usefulUtilities/smartBoard/screenshareViewer/screenshareClient.html");
133+static const ExternalResource::Bucket LOCAL_SCREENSHARE_WEB_ENTITY_BUCKET = ExternalResource::Bucket::HF_Content;
134+static const QString LOCAL_SCREENSHARE_WEB_ENTITY_PATH =
135+ "Experiences/Releases/usefulUtilities/smartBoard/screenshareViewer/screenshareClient.html";
135136 static const QString LOCAL_SCREENSHARE_WEB_ENTITY_HOST_TYPE = "local";
136137 void ScreenshareScriptingInterface::startScreenshare(const QUuid& screenshareZoneID,
137138 const QUuid& smartboardEntityID,
@@ -283,6 +284,8 @@ void ScreenshareScriptingInterface::handleSuccessfulScreenshareInfoGet(QNetworkR · 145 unmodified lines
283284 glm::vec3 localPosition(LOCAL_SCREENSHARE_WEB_ENTITY_LOCAL_POSITION);
284285 localPosition.z = _localWebEntityZOffset;
285286 localScreenshareWebEntityProps.setLocalPosition(localPosition);
287+ auto LOCAL_SCREENSHARE_WEB_ENTITY_URL = ExternalResource::getInstance()->getUrl(LOCAL_SCREENSHARE_WEB_ENTITY_BUCKET,
288+ LOCAL_SCREENSHARE_WEB_ENTITY_PATH);
286289 localScreenshareWebEntityProps.setSourceUrl(LOCAL_SCREENSHARE_WEB_ENTITY_URL);
287290 localScreenshareWebEntityProps.setParentID(_smartboardEntityID);
288291 localScreenshareWebEntityProps.setDimensions(LOCAL_SCREENSHARE_WEB_ENTITY_DIMENSIONS);