History

trying again -- frantic clicking on reload no longer appears to wedge things

Seth Alves committed 10 years ago

Commit 49769f71 parent 75329c86 files · +18 −27Browse files

Showing the changes to libraries/script-engine/src/ScriptEngine.cpp (1 of 6 files). Show all

Unified · Split

libraries/script-engine/src/ScriptEngine.cpp+3−6
@@ -290,7 +290,7 @@ void ScriptEngine::waitTillDoneRunning() { · 289 unmodified lines
290290 assert(workerThread != QThread::currentThread());
291291
292292 // Engine should be stopped already, but be defensive
293− stop(false);
293+ stop();
294294
295295 auto startedWaiting = usecTimestampNow();
296296 while (workerThread->isRunning()) {
@@ -944,12 +944,9 @@ void ScriptEngine::stopAllTimersForEntityScript(const EntityItemID& entityID) { · 647 unmodified lines
944944 void ScriptEngine::stop(bool marshal) {
945945 _isStopping = true; // this can be done on any thread
946946
947− // marshal us over to the correct thread
948947 if (marshal) {
949− if (QThread::currentThread() != thread()) {
950− QMetaObject::invokeMethod(this, "stop");
951− return;
952− }
948+ QMetaObject::invokeMethod(this, "stop");
949+ return;
953950 }
954951 if (!_isFinished) {
955952 _isFinished = true;