History

cleanup debugging and dead code

ZappoMan committed 11 years ago

Commit 49cf29c1 parent 47b0e2f1 file · +1 −21Browse files

Showing the changes to interface/src/Application.cpp (1 of 1 file). Show all

Unified · Split

interface/src/Application.cpp+1−21
@@ -679,7 +679,6 @@ Application::Application(int& argc, char** argv, QElapsedTimer &startup_time) : · 678 unmodified lines
679679 [this, entityScriptingInterface](const EntityItemID& entityItemID, const MouseEvent& event) {
680680 if (_keyboardFocusedItem != entityItemID) {
681681 _keyboardFocusedItem = UNKNOWN_ENTITY_ID;
682− qDebug() << "clickDownOnEntity.... _keyboardFocusedItem:" << UNKNOWN_ENTITY_ID;
683682 auto properties = entityScriptingInterface->getEntityProperties(entityItemID);
684683 if (EntityTypes::Web == properties.getType() && !properties.getLocked()) {
685684 auto entity = entityScriptingInterface->getEntityTree()->findEntityByID(entityItemID);
@@ -688,7 +687,6 @@ Application::Application(int& argc, char** argv, QElapsedTimer &startup_time) : · 2 unmodified lines
688687 webEntity->setProxyWindow(_window->windowHandle());
689688 _keyboardFocusedItem = entityItemID;
690689 _lastAcceptedKeyPress = usecTimestampNow();
691− qDebug() << "clickDownOnEntity.... _keyboardFocusedItem:" << entityItemID;
692690 }
693691 }
694692 }
@@ -698,7 +696,6 @@ Application::Application(int& argc, char** argv, QElapsedTimer &startup_time) : · 3 unmodified lines
698696 connect(getEntities(), &EntityTreeRenderer::mousePressOffEntity,
699697 [=](const RayToEntityIntersectionResult& entityItemID, const QMouseEvent* event, unsigned int deviceId) {
700698 _keyboardFocusedItem = UNKNOWN_ENTITY_ID;
701− qDebug() << "mousePressOffEntity... _keyboardFocusedItem:" << UNKNOWN_ENTITY_ID;
702699 });
703700 }
704701
@@ -1277,7 +1274,6 @@ bool Application::event(QEvent* event) { · 572 unmodified lines
12771274 QCoreApplication::sendEvent(webEntity->getEventHandler(), event);
12781275 if (event->isAccepted()) {
12791276 _lastAcceptedKeyPress = usecTimestampNow();
1280− qDebug() << "Application::event() key event... _lastAcceptedKeyPress:" << _lastAcceptedKeyPress;
12811277 return true;
12821278 }
12831279 }
@@ -1287,18 +1283,6 @@ bool Application::event(QEvent* event) { · 3 unmodified lines
12871283 default:
12881284 break;
12891285 }
1290−
1291− /*
1292− const quint64 LOSE_FOCUS_AFTER_ELAPSED_TIME = 30 * USECS_PER_SECOND; // if idle for 30 seconds, drop focus
1293− quint64 elapsedSinceAcceptedKeyPress = usecTimestampNow() - _lastAcceptedKeyPress;
1294− if (elapsedSinceAcceptedKeyPress > LOSE_FOCUS_AFTER_ELAPSED_TIME) {
1295− _keyboardFocusedItem = UNKNOWN_ENTITY_ID;
1296− qDebug() << "idle for 30 seconds.... _keyboardFocusedItem:" << UNKNOWN_ENTITY_ID;
1297− } else {
1298− qDebug() << "elapsedSinceAcceptedKeyPress:" << elapsedSinceAcceptedKeyPress;
1299− }
1300− */
1301−
13021286 }
13031287
13041288 switch (event->type()) {
@@ -2006,17 +1990,13 @@ void Application::idle() { · 701 unmodified lines
20061990 return; // bail early, nothing to do here.
20071991 }
20081992
1993+ // Drop focus from _keyboardFocusedItem if no keyboard messages for 30 seconds
20091994 if (!_keyboardFocusedItem.isInvalidID()) {
20101995 const quint64 LOSE_FOCUS_AFTER_ELAPSED_TIME = 30 * USECS_PER_SECOND; // if idle for 30 seconds, drop focus
20111996 quint64 elapsedSinceAcceptedKeyPress = usecTimestampNow() - _lastAcceptedKeyPress;
20121997 if (elapsedSinceAcceptedKeyPress > LOSE_FOCUS_AFTER_ELAPSED_TIME) {
20131998 _keyboardFocusedItem = UNKNOWN_ENTITY_ID;
2014− qDebug() << "Application::idle() no key messages for 30 seconds.... _keyboardFocusedItem: UNKNOWN_ENTITY_ID:" << UNKNOWN_ENTITY_ID;
2015− } else {
2016− qDebug() << "Application::idle() _keyboardFocusedItem:" << _keyboardFocusedItem << "elapsedSinceAcceptedKeyPress:" << elapsedSinceAcceptedKeyPress;
20171999 }
2018− } else {
2019− qDebug() << "Application::idle() no focused item, who cares...";
20202000 }
20212001
20222002 // Normally we check PipelineWarnings, but since idle will often take more than 10ms we only show these idle timing