History

Code cleanup

ksuprynowicz committed 3 years ago

Commit 5050cc91 parent d24038629 files · +57 −951Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptProgramV8Wrapper.cpp (1 of 29 files). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptProgramV8Wrapper.cpp+0−4
@@ -35,8 +35,6 @@ ScriptSyntaxCheckResultPointer ScriptProgramV8Wrapper::checkSyntax() { · 34 unmodified lines
35 35
36bool ScriptProgramV8Wrapper::compile() {36bool ScriptProgramV8Wrapper::compile() {
37 if (_isCompiled) {37 if (_isCompiled) {
38 // V8TODO is there a case where source code changes later and needs to be compiled again?
39 // V8TODO is same program used from multiple isolates
40 return true;38 return true;
41 }39 }
42 auto isolate = _engine->getIsolate();40 auto isolate = _engine->getIsolate();
@@ -49,7 +47,6 @@ bool ScriptProgramV8Wrapper::compile() { · 6 unmodified lines
49 int errorLineNumber = 0;47 int errorLineNumber = 0;
50 QString errorMessage = "";48 QString errorMessage = "";
51 QString errorBacktrace = "";49 QString errorBacktrace = "";
52 //ScriptSyntaxCheckResult::State state;
53 v8::TryCatch tryCatch(isolate);50 v8::TryCatch tryCatch(isolate);
54 v8::ScriptOrigin scriptOrigin(isolate, v8::String::NewFromUtf8(isolate, _url.toStdString().c_str()).ToLocalChecked());51 v8::ScriptOrigin scriptOrigin(isolate, v8::String::NewFromUtf8(isolate, _url.toStdString().c_str()).ToLocalChecked());
55 v8::Local<v8::Script> script;52 v8::Local<v8::Script> script;
@@ -77,7 +74,6 @@ bool ScriptProgramV8Wrapper::compile() { · 21 unmodified lines
77 }74 }
78 }75 }
79 }76 }
80 //V8TODO
81 _compileResult = ScriptSyntaxCheckResultV8Wrapper(ScriptSyntaxCheckResult::Error, errorColumnNumber, errorLineNumber, errorMessage, errorBacktrace);77 _compileResult = ScriptSyntaxCheckResultV8Wrapper(ScriptSyntaxCheckResult::Error, errorColumnNumber, errorLineNumber, errorMessage, errorBacktrace);
82 return false;78 return false;
83}79}