Showing the changes to libraries/script-engine/src/v8/ScriptProgramV8Wrapper.cpp (1 of 29 files). Show all
Unified · Split
| @@ -35,8 +35,6 @@ ScriptSyntaxCheckResultPointer ScriptProgramV8Wrapper::checkSyntax() { · 34 unmodified lines | ||
| 35 | 35 | |
| 36 | 36 | bool ScriptProgramV8Wrapper::compile() { |
| 37 | 37 | if (_isCompiled) { |
| 38 | − // V8TODO is there a case where source code changes later and needs to be compiled again? | |
| 39 | − // V8TODO is same program used from multiple isolates | |
| 40 | 38 | return true; |
| 41 | 39 | } |
| 42 | 40 | auto isolate = _engine->getIsolate(); |
| @@ -49,7 +47,6 @@ bool ScriptProgramV8Wrapper::compile() { · 6 unmodified lines | ||
| 49 | 47 | int errorLineNumber = 0; |
| 50 | 48 | QString errorMessage = ""; |
| 51 | 49 | QString errorBacktrace = ""; |
| 52 | − //ScriptSyntaxCheckResult::State state; | |
| 53 | 50 | v8::TryCatch tryCatch(isolate); |
| 54 | 51 | v8::ScriptOrigin scriptOrigin(isolate, v8::String::NewFromUtf8(isolate, _url.toStdString().c_str()).ToLocalChecked()); |
| 55 | 52 | v8::Local<v8::Script> script; |
| @@ -77,7 +74,6 @@ bool ScriptProgramV8Wrapper::compile() { · 21 unmodified lines | ||
| 77 | 74 | } |
| 78 | 75 | } |
| 79 | 76 | } |
| 80 | − //V8TODO | |
| 81 | 77 | _compileResult = ScriptSyntaxCheckResultV8Wrapper(ScriptSyntaxCheckResult::Error, errorColumnNumber, errorLineNumber, errorMessage, errorBacktrace); |
| 82 | 78 | return false; |
| 83 | 79 | } |