Showing the changes to libraries/script-engine/src/v8/ScriptValueIteratorV8Wrapper.cpp (1 of 29 files). Show all
Unified · Split
| @@ -20,7 +20,6 @@ V8ScriptValueIterator::V8ScriptValueIterator(ScriptEngineV8* engine, v8::Local<v · 19 unmodified lines | ||
| 20 | 20 | v8::Locker locker(isolate); |
| 21 | 21 | v8::Isolate::Scope isolateScope(isolate); |
| 22 | 22 | v8::HandleScope handleScope(isolate); |
| 23 | − // V8TODO Is this necessary? | |
| 24 | 23 | _context.Reset(isolate, _engine->getContext()); |
| 25 | 24 | auto context = _context.Get(isolate); |
| 26 | 25 | v8::Context::Scope contextScope(context); |
| @@ -83,7 +82,6 @@ V8ScriptValue V8ScriptValueIterator::value() { · 56 unmodified lines | ||
| 83 | 82 | if (!_object.Get(isolate)->Get(context, propertyName->ToString(context).ToLocalChecked()).ToLocal(&v8Value)) { |
| 84 | 83 | Q_ASSERT(false); |
| 85 | 84 | } |
| 86 | − //V8TODO: sometimes no value gets written to v8Value. This needs to be investigated and fixed. | |
| 87 | 85 | if (v8Value.IsEmpty()) { |
| 88 | 86 | qDebug() << "V8ScriptValueIterator::value: value handle is empty for key: " << *v8::String::Utf8Value(isolate, propertyName->ToString(context).ToLocalChecked()); |
| 89 | 87 | v8Value = v8::Undefined(isolate); |
| @@ -93,7 +91,6 @@ V8ScriptValue V8ScriptValueIterator::value() { · 3 unmodified lines | ||
| 93 | 91 | |
| 94 | 92 | ScriptValue::PropertyFlags ScriptValueIteratorV8Wrapper::flags() const { |
| 95 | 93 | //V8TODO |
| 96 | − //return (ScriptValue::PropertyFlags)(int)_value.flags(); | |
| 97 | 94 | return ScriptValue::PropertyFlags(); |
| 98 | 95 | } |
| 99 | 96 | |