History

Fixes for code review

ksuprynowicz committed 4 years ago

Commit 586bd7f1 parent e9bfdd416 files · +142 −117Browse files

Showing the changes to libraries/script-engine/src/ScriptValueUtils.cpp (1 of 16 files). Show all

Unified · Split

libraries/script-engine/src/ScriptValueUtils.cpp+13−3
@@ -29,6 +29,7 @@ · 28 unmodified lines
2929 #include "ScriptEngine.h"
3030 #include "ScriptEngineCast.h"
3131 #include "ScriptValueIterator.h"
32+#include "ScriptEngineLogging.h"
3233
3334 bool isListOfStrings(const ScriptValue& arg) {
3435 if (!arg.isArray()) {
@@ -78,9 +79,18 @@ void registerMetaTypes(ScriptEngine* engine) { · 43 unmodified lines
7879
7980 scriptRegisterMetaType<StencilMaskMode, stencilMaskModeToScriptValue, stencilMaskModeFromScriptValue>(engine);
8081
81− scriptRegisterMetaType<std::shared_ptr< MiniPromise >, promiseToScriptValue, promiseFromScriptValue>(engine);
82+ scriptRegisterMetaType<AnimationDetails, animationDetailsToScriptValue, animationDetailsFromScriptValue>(engine);
83+
84+ scriptRegisterMetaType<MeshProxy*, meshToScriptValue, meshFromScriptValue>(engine);
85+ scriptRegisterMetaType<MeshProxyList, meshesToScriptValue, meshesFromScriptValue>(engine);
8286
8387 scriptRegisterSequenceMetaType<QVector<unsigned int> >(engine);
88+ scriptRegisterSequenceMetaType<QVector<QUuid>>(engine);
89+ scriptRegisterSequenceMetaType<QVector<EntityItemID>>(engine);
90+
91+ scriptRegisterSequenceMetaType<QVector<glm::vec2>>(engine);
92+ scriptRegisterSequenceMetaType<QVector<glm::quat>>(engine);
93+ scriptRegisterSequenceMetaType<QVector<QString>>(engine);
8494 }
8595
8696 ScriptValue vec2ToScriptValue(ScriptEngine* engine, const glm::vec2& vec2) {
@@ -858,7 +868,7 @@ ScriptValue meshesToScriptValue(ScriptEngine* engine, const MeshProxyList& in) { · 771 unmodified lines
858868 bool meshesFromScriptValue(const ScriptValue& value, MeshProxyList& out) {
859869 ScriptValueIteratorPointer itr(value.newIterator());
860870
861− qDebug() << "in meshesFromScriptValue, value.length =" << value.property("length").toInt32();
871+ qDebug(scriptengine) << "in meshesFromScriptValue, value.length =" << value.property("length").toInt32();
862872
863873 while (itr->hasNext()) {
864874 itr->next();
@@ -866,7 +876,7 @@ bool meshesFromScriptValue(const ScriptValue& value, MeshProxyList& out) { · 1 unmodified line
866876 if (meshProxy) {
867877 out.append(meshProxy);
868878 } else {
869− qDebug() << "null meshProxy";
879+ qDebug(scriptengine) << "null meshProxy";
870880 }
871881 }
872882 return true;