History

V8 fixes

ksuprynowicz committed 3 years ago

Commit 5cf32a91 parent f65e72c14 files · +140 −15Browse files

Showing the changes to libraries/script-engine/src/AssetScriptingInterface.cpp (1 of 14 files). Show all

Unified · Split

libraries/script-engine/src/AssetScriptingInterface.cpp+7−0
@@ -73,6 +73,7 @@ void AssetScriptingInterface::uploadData(QString data, const ScriptValue& callba · 72 unmodified lines
7373 auto upload = DependencyManager::get<AssetClient>()->createUpload(dataByteArray);
7474
7575 Promise deferred = makePromise(__FUNCTION__);
76+ Q_ASSERT(engine);
7677 auto scriptEngine = engine();
7778 deferred->ready([=](QString error, QVariantMap result) {
7879 auto url = result.value("url").toString();
@@ -96,6 +97,7 @@ void AssetScriptingInterface::setMapping(QString path, QString hash, const Scrip · 17 unmodified lines
9697 auto handler = jsBindCallback(thisObject(), callback);
9798 auto setMappingRequest = assetClient()->createSetMappingRequest(path, hash);
9899 Promise deferred = makePromise(__FUNCTION__);
100+ Q_ASSERT(engine);
99101 auto scriptEngine = engine();
100102 deferred->ready([=](QString error, QVariantMap result) {
101103 jsCallback(handler, scriptEngine->newValue(error), result);
@@ -133,6 +135,7 @@ void AssetScriptingInterface::downloadData(QString urlString, const ScriptValue& · 31 unmodified lines
133135 auto assetRequest = assetClient->createRequest(hash);
134136
135137 Promise deferred = makePromise(__FUNCTION__);
138+ Q_ASSERT(engine);
136139 auto scriptEngine = engine();
137140 deferred->ready([=](QString error, QVariantMap result) {
138141 // FIXME: to remain backwards-compatible the signature here is "callback(data, n/a)"
@@ -196,6 +199,7 @@ void AssetScriptingInterface::getMapping(QString asset, const ScriptValue& callb · 57 unmodified lines
196199 JS_VERIFY(AssetUtils::isValidFilePath(path), "invalid ATP file path: " + asset + "(path:"+path+")");
197200 JS_VERIFY(callback.isFunction(), "expected second parameter to be a callback function");
198201 Promise promise = getAssetInfo(path);
202+ Q_ASSERT(engine);
199203 auto scriptEngine = engine();
200204 promise->ready([=](QString error, QVariantMap result) {
201205 jsCallback(handler, scriptEngine->newValue(error), scriptEngine->newValue(result.value("hash").toString()));
@@ -229,6 +233,7 @@ Promise AssetScriptingInterface::jsPromiseReady(Promise promise, const ScriptVal · 27 unmodified lines
229233 if (!jsVerify(handler.isValid(), "jsPromiseReady -- invalid callback handler")) {
230234 return nullptr;
231235 }
236+ Q_ASSERT(engine);
232237 auto scriptEngine = engine();
233238 return promise->ready([this, handler, scriptEngine](QString error, QVariantMap result) {
234239 jsCallback(handler, scriptEngine->newValue(error), result);
@@ -238,6 +243,7 @@ Promise AssetScriptingInterface::jsPromiseReady(Promise promise, const ScriptVal · 3 unmodified lines
238243 void AssetScriptingInterface::jsCallback(const ScriptValue& handler,
239244 const ScriptValue& error, const ScriptValue& result) {
240245 Q_ASSERT(thread() == QThread::currentThread());
246+ Q_ASSERT(engine);
241247 auto errorValue = !error.toBool() ? engine()->nullValue() : error;
242248 JS_VERIFY(handler.isObject() && handler.property("callback").isFunction(),
243249 QString("jsCallback -- .callback is not a function (%1)")
@@ -536,6 +542,7 @@ void AssetScriptingInterface::loadFromCache(const ScriptValue& options, const Sc · 292 unmodified lines
536542 }
537543
538544 bool AssetScriptingInterface::canWriteCacheValue(const QUrl& url) {
545+ Q_ASSERT(engine);
539546 auto scriptManager = engine()->manager();
540547 if (!scriptManager) {
541548 return false;

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t