History

Fixed crash on standing up from sit script

ksuprynowicz committed 3 years ago

Commit 5e5003f1 parent 8e718261 file · +4 −2Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp (1 of 1 file). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp+4−2
@@ -1526,12 +1526,14 @@ void ScriptSignalV8Proxy::disconnect(ScriptValue arg0, ScriptValue arg1) { · 1525 unmodified lines
1526 v8::Local<v8::Array> newArray = v8::Array::New(isolate, length - 1);1526 v8::Local<v8::Array> newArray = v8::Array::New(isolate, length - 1);
1527 bool foundIt = false;1527 bool foundIt = false;
1528 int newIndex = 0;1528 int newIndex = 0;
1529 for (int idx = 0; idx < length && !foundIt; ++idx) {1529 //for (int idx = 0; idx < length && !foundIt; ++idx) {
1530 for (int idx = 0; idx < length; ++idx) {
1530 v8::Local<v8::Value> entry = destArray->Get(destFunctionContext, idx).ToLocalChecked();1531 v8::Local<v8::Value> entry = destArray->Get(destFunctionContext, idx).ToLocalChecked();
1531 // For debugging:1532 // For debugging:
1532 {1533 {
1533 _engine->logBacktrace("ScriptSignalV8Proxy::disconnect");1534 _engine->logBacktrace("ScriptSignalV8Proxy::disconnect");
1534 qDebug() << "ScriptSignalV8Proxy::disconnect: entry details: " << _engine->scriptValueDebugDetailsV8(V8ScriptValue(_engine, entry));1535 qDebug() << "ScriptSignalV8Proxy::disconnect: entry details: " << _engine->scriptValueDebugDetailsV8(V8ScriptValue(_engine, entry))
1536 << " Array: " << _engine->scriptValueDebugDetailsV8(V8ScriptValue(_engine, destArray));
1535 Q_ASSERT(entry->IsObject());1537 Q_ASSERT(entry->IsObject());
1536 V8ScriptValue v8EntryObject(_engine, entry);1538 V8ScriptValue v8EntryObject(_engine, entry);
1537 Q_ASSERT(ScriptObjectV8Proxy::unwrapProxy(v8EntryObject));1539 Q_ASSERT(ScriptObjectV8Proxy::unwrapProxy(v8EntryObject));