History

Fixed crash on standing up from sit script

ksuprynowicz committed 3 years ago

Commit 5e5003f1 parent 8e718261 file · +4 −2Browse files

Showing the changes to libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp (1 of 1 file). Show all

Unified · Split

libraries/script-engine/src/v8/ScriptObjectV8Proxy.cpp+4−2
@@ -1526,12 +1526,14 @@ void ScriptSignalV8Proxy::disconnect(ScriptValue arg0, ScriptValue arg1) { · 1525 unmodified lines
15261526 v8::Local<v8::Array> newArray = v8::Array::New(isolate, length - 1);
15271527 bool foundIt = false;
15281528 int newIndex = 0;
1529− for (int idx = 0; idx < length && !foundIt; ++idx) {
1529+ //for (int idx = 0; idx < length && !foundIt; ++idx) {
1530+ for (int idx = 0; idx < length; ++idx) {
15301531 v8::Local<v8::Value> entry = destArray->Get(destFunctionContext, idx).ToLocalChecked();
15311532 // For debugging:
15321533 {
15331534 _engine->logBacktrace("ScriptSignalV8Proxy::disconnect");
1534− qDebug() << "ScriptSignalV8Proxy::disconnect: entry details: " << _engine->scriptValueDebugDetailsV8(V8ScriptValue(_engine, entry));
1535+ qDebug() << "ScriptSignalV8Proxy::disconnect: entry details: " << _engine->scriptValueDebugDetailsV8(V8ScriptValue(_engine, entry))
1536+ << " Array: " << _engine->scriptValueDebugDetailsV8(V8ScriptValue(_engine, destArray));
15351537 Q_ASSERT(entry->IsObject());
15361538 V8ScriptValue v8EntryObject(_engine, entry);
15371539 Q_ASSERT(ScriptObjectV8Proxy::unwrapProxy(v8EntryObject));