History

bail early from irrecoverable retry situations

humbletim committed 10 years ago

Commit 61452c21 parent 2139e971 file · +8 −1Browse files

Showing the changes to libraries/script-engine/src/ScriptCache.cpp (1 of 1 file). Show all

Unified · Split

libraries/script-engine/src/ScriptCache.cpp+8−1
@@ -202,7 +202,14 @@ void ScriptCache::scriptContentAvailable() { · 201 unmodified lines
202202 finished = true;
203203 qCDebug(scriptengine) << "Done downloading script at:" << url.toString();
204204 } else {
205− if (scriptRequest.numRetries < MAX_RETRIES) {
205+ auto result = req->getResult();
206+ bool irrecoverable =
207+ result == ResourceRequest::AccessDenied ||
208+ result == ResourceRequest::InvalidURL ||
209+ result == ResourceRequest::NotFound ||
210+ scriptRequest.numRetries >= MAX_RETRIES;
211+
212+ if (!irrecoverable) {
206213 ++scriptRequest.numRetries;
207214
208215 qDebug() << "Script request failed: " << url;