History

V8 related cleanup

ksuprynowicz committed 3 years ago

Commit 61924161 parent b3997bf12 files · +11 −44Browse files

Showing the changes to interface/src/raypick/PointerScriptingInterface.cpp (1 of 12 files). Show all

Unified · Split

interface/src/raypick/PointerScriptingInterface.cpp+0−3
@@ -630,7 +630,6 @@ ScriptValue stylusPointerPropertiesToScriptValue(ScriptEngine* engine, const Sty · 629 unmodified lines
630630 return engine->newVariant(QVariant(in.properties));
631631 }
632632
633−//V8TODO: adapt render states to what parabola expects
634633 bool stylusPointerPropertiesFromScriptValue(const ScriptValue& value, StylusPointerProperties& out) {
635634 // This copies properties from script value, but also converts entity properties of entities used in render states
636635 // from JS objects into EntityItemProperties
@@ -670,7 +669,6 @@ bool stylusPointerPropertiesFromScriptValue(const ScriptValue& value, StylusPoin · 33 unmodified lines
670669 stateMap.insert("endPropertyIndex", QVariant(out.entityProperties.length()));
671670 out.entityProperties.append(endProperties);
672671 }
673− // V8TODO: Check if path is a polyline and if values are valid
674672 renderStates[i].setValue(stateMap);
675673 }
676674 }
@@ -727,7 +725,6 @@ bool parabolaPointerPropertiesFromScriptValue(const ScriptValue& value, Parabola · 50 unmodified lines
727725 out.entityProperties.append(endProperties);
728726 qDebug() << "parabolaPointerPropertiesFromScriptValue : added end entity";
729727 }
730− // V8TODO: Check if path is a polyline and if values are valid
731728 renderStates[i].setValue(stateMap);
732729 }
733730 }