History

Merge pull request #5530 from ZappoMan/RenderableModelEntityItemOptimization

optimizations to RenderableModelEntityItem::render()

Brad Davis committed 11 years ago

Commit 64fcd2d2 parents b1e6953 cec0f8e7 files · +50 −27Browse files

Showing the changes to libraries/render-utils/src/Model.cpp (1 of 7 files). Show all

Unified · Split

libraries/render-utils/src/Model.cpp+7−8
@@ -54,6 +54,7 @@ static int modelPointerTypeId = qRegisterMetaType<QPointer<Model> >(); · 53 unmodified lines
5454 static int weakNetworkGeometryPointerTypeId = qRegisterMetaType<QWeakPointer<NetworkGeometry> >();
5555 static int vec3VectorTypeId = qRegisterMetaType<QVector<glm::vec3> >();
5656 float Model::FAKE_DIMENSION_PLACEHOLDER = -1.0f;
57+#define HTTP_INVALID_COM "http://invalid.com"
5758
5859 Model::Model(RigPointer rig, QObject* parent) :
5960 QObject(parent),
@@ -67,7 +68,8 @@ Model::Model(RigPointer rig, QObject* parent) : · 7 unmodified lines
6768 _cauterizeBones(false),
6869 _lodDistance(0.0f),
6970 _pupilDilation(0.0f),
70− _url("http://invalid.com"),
71+ _url(HTTP_INVALID_COM),
72+ _urlAsString(HTTP_INVALID_COM),
7173 _isVisible(true),
7274 _blendNumber(0),
7375 _appliedBlendNumber(0),
@@ -181,17 +183,12 @@ void Model::RenderPipelineLib::initLocations(gpu::ShaderPointer& program, Model: · 107 unmodified lines
181183 locations.texcoordMatrices = program->getUniforms().findLocation("texcoordMatrices");
182184 locations.emissiveParams = program->getUniforms().findLocation("emissiveParams");
183185 locations.glowIntensity = program->getUniforms().findLocation("glowIntensity");
184−
185186 locations.normalFittingMapUnit = program->getTextures().findLocation("normalFittingMap");
186−
187187 locations.specularTextureUnit = program->getTextures().findLocation("specularMap");
188188 locations.emissiveTextureUnit = program->getTextures().findLocation("emissiveMap");
189−
190189 locations.materialBufferUnit = program->getBuffers().findLocation("materialBuffer");
191190 locations.lightBufferUnit = program->getBuffers().findLocation("lightBuffer");
192−
193191 locations.clusterMatrices = program->getUniforms().findLocation("clusterMatrices");
194−
195192 locations.clusterIndices = program->getInputs().findLocation("inSkinClusterIndex");
196193 locations.clusterWeights = program->getInputs().findLocation("inSkinClusterWeight");
197194 }
@@ -1083,6 +1080,7 @@ void Model::setURL(const QUrl& url, const QUrl& fallback, bool retainCurrent, bo · 885 unmodified lines
10831080 invalidCalculatedMeshBoxes();
10841081
10851082 _url = url;
1083+ _urlAsString = _url.toString();
10861084
10871085 onInvalidate();
10881086
@@ -1866,8 +1864,9 @@ void Model::pickPrograms(gpu::Batch& batch, RenderMode mode, bool translucent, f · 777 unmodified lines
18661864 batch._glUniform1f(locations->glowIntensity, DEFAULT_GLOW_INTENSITY);
18671865 }
18681866
1869− if ((locations->normalFittingMapUnit > -1)) {
1870− batch.setResourceTexture(locations->normalFittingMapUnit, DependencyManager::get<TextureCache>()->getNormalFittingTexture());
1867+ if ((locations->normalFittingMapUnit > -1)) {
1868+ batch.setResourceTexture(locations->normalFittingMapUnit,
1869+ DependencyManager::get<TextureCache>()->getNormalFittingTexture());
18711870 }
18721871 }
18731872