Further exception work on V8

* Get rid of maybeEmitUncaughtException * Mostly get rid of makeError * Introduce exception hierarchy, change exceptions to shared_ptr * Simplify exception throwing code

Dale Glass committed 3 years ago

Commit 67e7a731 parent c0e62c510 files · +249 −260Browse files

Showing the changes to libraries/script-engine/src/ScriptManagerScriptingInterface.cpp (1 of 10 files). Show all

Unified · Split

libraries/script-engine/src/ScriptManagerScriptingInterface.cpp+8−1

@@ -30,5 +30,12 @@ · 29 unmodified lines
30	30	connect(_manager, &ScriptManager::doneRunning, this, &ScriptManagerScriptingInterface::doneRunning);
31	31	connect(_manager, &ScriptManager::entityScriptDetailsUpdated, this, &ScriptManagerScriptingInterface::entityScriptDetailsUpdated);
32	32	connect(_manager, &ScriptManager::entityScriptPreloadFinished, this, &ScriptManagerScriptingInterface::entityScriptPreloadFinished);
33		− connect(_manager, &ScriptManager::unhandledException, this, &ScriptManagerScriptingInterface::unhandledException);
	33	+ connect(_manager, &ScriptManager::unhandledException, this, &ScriptManagerScriptingInterface::scriptManagerException);
	34	+ }
	35	+
	36	+ void ScriptManagerScriptingInterface::scriptManagerException(std::shared_ptr<ScriptException> exception) {
	37	+ // V8TODO: What should we actually handle here?
	38	+
	39	+
	40	+ // emit unhandledException(exception.thrownValue);
34	41	}