History

added requested changes

luiscuenca committed 8 years ago

Commit 689fbd21 parent 2ac7fca6 files · +29 −31Browse files

Showing the changes to interface/src/Application.cpp (1 of 6 files). Show all

Unified · Split

interface/src/Application.cpp+13−17
@@ -1231,7 +1231,7 @@ Application::Application(int& argc, char** argv, QElapsedTimer& startupTimer, bo · 1230 unmodified lines
12311231
12321232 connect(scriptEngines, &ScriptEngines::scriptsReloading, scriptEngines, [this] {
12331233 getEntities()->reloadEntityScripts();
1234− loadAvatarScripts(getMyAvatar()->getSkeletonModel()->getFBXGeometry().scripts);
1234+ loadAvatarScripts(getMyAvatar()->getScriptUrls());
12351235 }, Qt::QueuedConnection);
12361236
12371237 connect(scriptEngines, &ScriptEngines::scriptLoadError,
@@ -4728,16 +4728,14 @@ void Application::init() { · 3490 unmodified lines
47284728 }
47294729
47304730 void Application::loadAvatarScripts(const QVector<QString>& urls) {
4731− if (urls.size() > 0) {
4732− auto scriptEngines = DependencyManager::get<ScriptEngines>();
4733− auto runningScripts = scriptEngines->getRunningScripts();
4734− for (auto url : urls) {
4735− int index = runningScripts.indexOf(url);
4736− if (index < 0) {
4737− auto scriptEnginePointer = scriptEngines->loadScript(url, false);
4738− if (scriptEnginePointer) {
4739− scriptEnginePointer->setType(ScriptEngine::Type::AVATAR);
4740− }
4731+ auto scriptEngines = DependencyManager::get<ScriptEngines>();
4732+ auto runningScripts = scriptEngines->getRunningScripts();
4733+ for (auto url : urls) {
4734+ int index = runningScripts.indexOf(url);
4735+ if (index < 0) {
4736+ auto scriptEnginePointer = scriptEngines->loadScript(url, false);
4737+ if (scriptEnginePointer) {
4738+ scriptEnginePointer->setType(ScriptEngine::Type::AVATAR);
47414739 }
47424740 }
47434741 }
@@ -4746,12 +4744,10 @@ void Application::loadAvatarScripts(const QVector<QString>& urls) { · 2 unmodified lines
47464744 void Application::unloadAvatarScripts() {
47474745 auto scriptEngines = DependencyManager::get<ScriptEngines>();
47484746 auto urls = scriptEngines->getRunningScripts();
4749− if (urls.size() > 0) {
4750− for (auto url : urls) {
4751− auto scriptEngine = scriptEngines->getScriptEngine(url);
4752− if (scriptEngine->getType() == ScriptEngine::Type::AVATAR) {
4753− scriptEngines->stopScript(url, false);
4754− }
4747+ for (auto url : urls) {
4748+ auto scriptEngine = scriptEngines->getScriptEngine(url);
4749+ if (scriptEngine->getType() == ScriptEngine::Type::AVATAR) {
4750+ scriptEngines->stopScript(url, false);
47554751 }
47564752 }
47574753 }