History

Fixed crash with asset scripting crash

ksuprynowicz committed 3 years ago

Commit 6c1fd881 parent ca577f23 files · +11 −7Browse files

Showing the changes to libraries/script-engine/src/AssetScriptingInterface.cpp (1 of 3 files). Show all

Unified · Split

libraries/script-engine/src/AssetScriptingInterface.cpp+2−2
@@ -43,7 +43,7 @@ STATIC_SCRIPT_TYPES_INITIALIZER((+[](ScriptManager* manager){ · 42 unmodified lines
4343 }));
4444
4545
46−AssetScriptingInterface::AssetScriptingInterface(QObject* parent) : BaseAssetScriptingInterface(parent) {
46+AssetScriptingInterface::AssetScriptingInterface(ScriptManager* parent) : BaseAssetScriptingInterface(parent), _scriptManager(parent) {
4747 qCDebug(scriptengine) << "AssetScriptingInterface::AssetScriptingInterface" << parent;
4848 }
4949
@@ -246,7 +246,7 @@ void AssetScriptingInterface::jsCallback(const ScriptValue& handler, · 196 unmodified lines
246246 Q_ASSERT(thread() == QThread::currentThread());
247247 Q_ASSERT(engine);
248248 //V8TODO: which kind of script context guard needs to be used here?
249− ScriptContextGuard scriptContextGuard(engine()->currentContext());
249+ ScriptContextGuard scriptContextGuard(_scriptManager->engine()->currentContext());
250250 auto errorValue = !error.toBool() ? engine()->nullValue() : error;
251251 JS_VERIFY(handler.isObject() && handler.property("callback").isFunction(),
252252 QString("jsCallback -- .callback is not a function (%1)")