History

remove unnecessary list copying when retrieving a list of plugins

Heather Anderson committed 5 years ago

Commit 6e4e0df1 parent 88b00459 files · +64 −64Browse files

Showing the changes to assignment-client/src/scripts/EntityScriptServer.cpp (1 of 9 files). Show all

Unified · Split

assignment-client/src/scripts/EntityScriptServer.cpp+4−4
@@ -399,10 +399,10 @@ void EntityScriptServer::nodeKilled(SharedNodePointer killedNode) { · 398 unmodified lines
399399 void EntityScriptServer::negotiateAudioFormat() {
400400 auto nodeList = DependencyManager::get<NodeList>();
401401 auto negotiateFormatPacket = NLPacket::create(PacketType::NegotiateAudioFormat);
402− auto codecPlugins = PluginManager::getInstance()->getCodecPlugins();
402+ const auto& codecPlugins = PluginManager::getInstance()->getCodecPlugins();
403403 quint8 numberOfCodecs = (quint8)codecPlugins.size();
404404 negotiateFormatPacket->writePrimitive(numberOfCodecs);
405− for (auto& plugin : codecPlugins) {
405+ for (const auto& plugin : codecPlugins) {
406406 auto codecName = plugin->getName();
407407 negotiateFormatPacket->writeString(codecName);
408408 }
@@ -433,8 +433,8 @@ void EntityScriptServer::selectAudioFormat(const QString& selectedCodecName) { · 24 unmodified lines
433433 _codec = nullptr;
434434 }
435435
436− auto codecPlugins = PluginManager::getInstance()->getCodecPlugins();
437− for (auto& plugin : codecPlugins) {
436+ const auto& codecPlugins = PluginManager::getInstance()->getCodecPlugins();
437+ for (const auto& plugin : codecPlugins) {
438438 if (_selectedCodecName == plugin->getName()) {
439439 _codec = plugin;
440440 _encoder = plugin->createEncoder(AudioConstants::SAMPLE_RATE, AudioConstants::MONO);