History

Fixes to most scripting-related warnings

ksuprynowicz committed 4 years ago

Commit 6f321731 parent a14c64435 files · +195 −149Browse files

Showing the changes to libraries/script-engine/src/qtscript/ScriptObjectQtProxy.cpp (1 of 35 files). Show all

Unified · Split

libraries/script-engine/src/qtscript/ScriptObjectQtProxy.cpp+4−1
@@ -77,6 +77,10 @@ QScriptValue ScriptObjectQtProxy::newQObject(ScriptEngineQtScript* engine, QObje · 76 unmodified lines
77 case ScriptEngine::AutoOwnership:77 case ScriptEngine::AutoOwnership:
78 ownsObject = !object->parent();78 ownsObject = !object->parent();
79 break;79 break;
80 default:
81 ownsObject = false;
82 qCritical() << "Wrong ScriptEngine::ValueOwnership value: " << ownership;
83 break;
80 }84 }
81 85
82 // create the wrapper86 // create the wrapper
@@ -312,7 +316,6 @@ QScriptValue ScriptObjectQtProxy::property(const QScriptValue& object, const QSc · 229 unmodified lines
312 int propId = id & ~TYPE_MASK;316 int propId = id & ~TYPE_MASK;
313 PropertyDefMap::const_iterator lookup = _props.find(propId);317 PropertyDefMap::const_iterator lookup = _props.find(propId);
314 if (lookup == _props.cend()) return QScriptValue();318 if (lookup == _props.cend()) return QScriptValue();
315 const PropertyDef& propDef = lookup.value();
316 319
317 QMetaProperty prop = metaObject->property(propId);320 QMetaProperty prop = metaObject->property(propId);
318 ScriptValue scriptThis = ScriptValue(new ScriptValueQtWrapper(_engine, object));321 ScriptValue scriptThis = ScriptValue(new ScriptValueQtWrapper(_engine, object));

Keyboard shortcuts

General

Show keyboard shortcuts
?
Focus the current search
/

Issues and pull requests

Open filters
f

Issues, pull requests and Inbox

Select next item
j↓
Select previous item
k↑
Open selected item
Enter
Dismiss filters or clear selection
Esc

Repository code

Go to file
t